Skip to content

fixes #42 , implemented the Pattern Type for Indicators vocabulary #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

rhohimer
Copy link
Collaborator

@rhohimer rhohimer commented May 1, 2025

No description provided.

@rhohimer rhohimer requested review from uscholdm and coltonglasgow May 1, 2025 17:20
@rhohimer rhohimer self-assigned this May 1, 2025
Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Comment on lines 92 to 97
gist:PatternType
a owl:Class ;
rdfs:subClassOf gist:StixCategoryObject ;
skos:definition "PatternType is a non-exhaustive, open vocabulary that covers common pattern languages and is intended to characterize the pattern language that an indicator pattern is expressed in."^^xsd:string ;
skos:prefLabel "Pattern Type"^^xsd:string ;
.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gist:PatternType
a owl:Class ;
rdfs:subClassOf gist:StixCategoryObject ;
skos:definition "PatternType is a non-exhaustive, open vocabulary that covers common pattern languages and is intended to characterize the pattern language that an indicator pattern is expressed in."^^xsd:string ;
skos:prefLabel "Pattern Type"^^xsd:string ;
.
gist:PatternType
a owl:Class ;
rdfs:subClassOf gist:StixCategoryObject ;
skos:definition "A language used to express an indicator pattern."^^xsd:string ;
skos:example "Sigma, Stix"^^xsd:string ;
skos:scopeNote "STIX 2.1 description:
PatternType is a non-exhaustive, open vocabulary that covers common pattern languages and is intended to characterize the pattern language that an indicator pattern is expressed in."^^xsd:string ;
skos:prefLabel "Pattern Type"^^xsd:string ;
.

Comment on lines 1093 to 1098
gist:_PatternType_Pcre
a gist:AccountType ;
skos:definition """STIX 2.1 description:
Specifies the Perl Compatible Regular Expressions language [PCRE]."""^^xsd:string ;
skos:prefLabel "pcre"^^xsd:string ;
.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Case inconsistency: Pcre & pcre
Or maybe label should be words spelled out and [create and] use gist:abbreviation for the short form (make it a subproperty of skos:note).

@rhohimer rhohimer merged commit 075a36a into develop May 7, 2025
@rhohimer rhohimer deleted the issue-42-pattern-type-vocab branch May 7, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants