Issue 47: implement the stix 21 windows integrity level enumeration #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2025
uscholdm
requested changes
Jun 6, 2025
| @@ -168,6 +168,21 @@ gist:ThreatActorType | |||
| rdfs:subClassOf gist:StixCategoryObject ; | |||
| . | |||
|
|
|||
| gist:WindowsIntegrityLevel | |||
Comment on lines
+176
to
+178
| ● Process (Windows Process extension) | ||
|
|
||
|
|
There was a problem hiding this comment.
Strange - a single bullet and two blank lines. Its a poor definition. I wonder if we should have a gist:stixDefinition (sub-property of skos:definition) and use it similar to how we use stixTerm. It would be a lot of work though to come up with good definitions. Here is a stab:
skos:definition "A category indicating the trustworthiness of an object in the Windows environment."^^xsd:string ;
| skos:prefLabel "System Integrity Level"^^xsd:string ; | ||
| gist:stixTerm "system"^^xsd:string ; | ||
| . | ||
|
|
There was a problem hiding this comment.
IRI - prefLabel mismatch. Should be more like:
gist:_WindowsIntegrityLevel_high
a gist:WindowsIntegrityLevel ;
skos:definition """STIX 2.1 description:
A high level of integrity."""^^xsd:string ;
skos:prefLabel "high"^^xsd:string ; <==
gist:stixTerm "high"^^xsd:string ;
.
Do like the others, for consistency.
Also, this make stixTerm repetetive, not sure what policy to adopt for this case.
This was referenced Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47
Looking for feedback/suggestions on what should be used for
gist:sequenceif this is really an enumeration that should use the triple pattern, or if the current set of triples is satisfactory.Reference to the STIX 2.1 vocab source: STIX 2.1 Windows™ Integrity Level Enumeration