Skip to content

Bundle.yaml updates. Fixes #922 #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 26, 2023
Merged

Bundle.yaml updates. Fixes #922 #930

merged 5 commits into from
Jul 26, 2023

Conversation

rjyounes
Copy link
Collaborator

@rjyounes rjyounes commented Jul 25, 2023 •
edited
Loading

Fixes #922.

Two changes:

  • gistValidationAnnotations.ttl is not included in download package
  • rdfsAnnotations files have versioned filenames prefixed with "gist" - e.g., "gistRdfsAnnotations12.0.1.ttl" instead of "rdfsAnnotations.ttl".

I've tested these on my end. Please run the bundler and test for both of these changes.

dylan-sa
dylan-sa requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@dylan-sa dylan-sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording tweak to release note, but otherwise looking good to me.

stevenchalem
stevenchalem approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@stevenchalem stevenchalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked fine for me.

@rjyounes @dylan-sa
Update docs/release_notes/issue-922-bundler
3a61f22 
Co-authored-by: dylan-sa <90274189+dylan-sa@users.noreply.github.com>
@rjyounes rjyounes marked this pull request as draft July 26, 2023 14:05
@rjyounes rjyounes marked this pull request as ready for review July 26, 2023 14:37
@dylan-sa dylan-sa merged commit 666b483 into release/12.0.1 Jul 26, 2023
@dylan-sa dylan-sa deleted the release/issue-922-bundler-fixes branch July 26, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenchalem stevenchalem stevenchalem approved these changes

@dylan-sa dylan-sa dylan-sa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjyounes @stevenchalem @dylan-sa