Feature/816 migration scripts #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a new folder structure for migration queries - Two top level directories called action and reporting each containing a directory for default and ngraph queries. - Simplified query file names with new directory structure - Lots of small changes to queries - Split multi query files into individual files - Updated percentage action query - Tested queries on Apache Jena, GraphDB, and Allegro Graph
Created new directories under `migration/v12.0/queries/reporting/` for old and new gist namespace validation scripts. - Old namespace queries should be used for validating before migration - New namespace queries should be used for validating after migration - Added a README to old and new namespace directories stating the above two bullet points
- Improved directory structure for report queries - Following action directory format (action/default|ngraphs) - Added README in report directory with directory layout - Updated `migrate_local.yaml` with new directory structure - README for v12.0 migrations (WiP)
26 tasks
coltonglasgow
commented
May 26, 2023
Comment on lines
79
to
119
| # validation | ||
| # default | ||
| - action: "verify" | ||
| message: "Check for other items that should be reviewed." | ||
| type: "construct" | ||
| inference: "none" | ||
| stopOnFail: false | ||
| target: "{report}" | ||
| endpoint: | ||
| query_uri: "{endpoint}" | ||
| user: "{user}" | ||
| password: "{password}" | ||
| queries: | ||
| source: "{reporting_queries_path_default}/" | ||
| includes: | ||
| - "detect_removed.rq" | ||
| - "detect_renamed.rq" | ||
| - "detect_old_namespace_subject.rq" | ||
| - "detect_old_namespace_predicate.rq" | ||
| - "detect_old_namespace_object.rq" | ||
| - "detect_old_namespace_graph.rq" | ||
| # ngraphs | ||
| - action: "verify" | ||
| message: "Check for other items that should be reviewed." | ||
| type: "construct" | ||
| inference: "none" | ||
| stopOnFail: false | ||
| target: "{report}" | ||
| endpoint: | ||
| query_uri: "{endpoint}" | ||
| user: "{user}" | ||
| password: "{password}" | ||
| queries: | ||
| source: "{reporting_queries_path_ngraphs}/" | ||
| includes: | ||
| - "detect_removed.rq" | ||
| - "detect_renamed.rq" | ||
| - "detect_old_namespace_subject.rq" | ||
| - "detect_old_namespace_predicate.rq" | ||
| - "detect_old_namespace_object.rq" | ||
| - "detect_old_namespace_graph.rq" |
There was a problem hiding this comment.
I have been unable to test the validation against an endpoint. I am getting an error back that appears to be from the endpoint, I may have the wrong URL. I have tries several databases with no luck. @Jamie-SA, could you provide me with the endpoint URL for AGraph or GraphDB please.
Jamie-SA
requested changes
Jun 8, 2023
migration/v12.0/queries/report/default/new_namespace/detect_renamed.rq
Outdated
Show resolved
Hide resolved
migration/v12.0/queries/report/default/old_namespace/detect_old_namespace_object.rq
Outdated
Show resolved
Hide resolved
migration/v12.0/queries/report/default/old_namespace/detect_old_namespace_predicate.rq
Outdated
Show resolved
Hide resolved
migration/v12.0/queries/report/ngraphs/old_namespace/detect_old_namespace_graph.rq
Outdated
Show resolved
Hide resolved
migration/v12.0/queries/report/ngraphs/old_namespace/detect_old_namespace_object.rq
Outdated
Show resolved
Hide resolved
migration/v12.0/queries/report/ngraphs/old_namespace/detect_old_namespace_predicate.rq
Outdated
Show resolved
Hide resolved
migration/v12.0/queries/report/ngraphs/old_namespace/detect_old_namespace_subject.rq
Outdated
Show resolved
Hide resolved
migration/v12.0/queries/report/ngraphs/old_namespace/detect_renamed.rq
Outdated
Show resolved
Hide resolved
|
Colton is out for a couple of weeks so I'm going to work on addressing some of the issues I found during my review. |
Jamie-SA
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.