Skip to content

Update annotations on gist:isAllocatedBy. Fixes #530. #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 9, 2023

Conversation

wslooney
Copy link
Contributor

…AllocatedBy

@wslooney wslooney requested review from rjyounes and dylan-sa March 29, 2023 20:55
Copy link
Contributor

@dylan-sa dylan-sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for the domainIncludes statement, but looks good even if you decide against it. Can add 'Fixes #n' to the title to ensure automated closing of the issue.

@rjyounes rjyounes changed the title Change prefLabel; add skos example and gist domainIncludes to gist:is… Update annotations on gist:isAllocatedBy. Fixes #530. Mar 30, 2023
@rjyounes
Copy link
Collaborator

I've updated the PR title. Note that GitHub will add something automatically but you an edit it. And as Dylan points out, you should add the "fixes" keyword to tie the PR to the issue. The project label should also be applied to track it with the release.

@Jamie-SA Jamie-SA mentioned this pull request Apr 19, 2023
26 tasks
Copy link
Contributor

@dylan-sa dylan-sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wslooney - Just noticed we need a release note for this one too, following our new process of creating a separate release note file for each PR.

gistCore.ttl Outdated
@@ -17,6 +17,26 @@
gist:license "https://creativecommons.org/licenses/by-sa/3.0/"^^xsd:string ;
.

skos:scopeNote
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielHadad These are Protege artifacts that need to be removed from the file before commit.

@@ -0,0 +1,6 @@
### Minor Updates

* Updated `gist:isAllocatedBy`, as per issue [#530](https://github.com/semanticarts/gist/issues/530).
Copy link
Collaborator

@rjyounes rjyounes May 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these items are worth calling out separately. You could say, "Broadened definition of gist:isAllocatedBy to include entities other than IDs, and updated other annotations, as per..."

gistCore.ttl Outdated
@@ -3450,8 +3470,14 @@ gist:isAllocatedBy
gist:Person
) ;
] ;
skos:definition "Connection between an ID and the thing that minted the ID. It may be a person or organization, or could be an algorithm (next available or random number generator)"^^xsd:string ;
skos:definition "Relates the subject to whoever/whatever assigns or distributes it."^^xsd:string ;
skos:example "A U.S. Social Security number is allocated by the U.S. Social Security Administration. The gist:MediaType 'CVS' is allocated by the gist Development Team."^^xsd:string ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The csv example isn't good because, as you can see from the namespaces, these are IANA terms, which we have simply assigned a type gist:MediaType. How about "The media type https://www.iana.org/assignments/media-types/text/csv" is allocated by the Internet Assigned Numbers Authority (IANA)."?

@rjyounes rjyounes force-pushed the feature/issue-530-change-allocatedBy-annoations branch from 8cd9a98 to e94b916 Compare May 9, 2023 15:13
@rjyounes rjyounes merged commit 911a411 into develop May 9, 2023
@rjyounes rjyounes deleted the feature/issue-530-change-allocatedBy-annoations branch May 9, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants