Add windows support to setup. Fixes #797

[Jamie-SA]

Fixes #797
Modified the setup script so that it might work in the windows command window.
I haven't tested it yet on Windows.

If we decide to go forward with this, I will update the documentation to match the name change and additional capabilities.

[dylan-sa]

I tested the setup.cmd script in CMD and PowerShell, and it works perfectly. The unix folks won't be able to run this one, though, right? For example, I don't think I can run setup.cmd in ZSH on my Mac. Maybe we want to retain both scripts?

[Jamie-SA]

The unix folks won't be able to run this one, though, right? For example, I don't think I can run setup.cmd in ZSH on my Mac.

This worked on linux and I think it will work on Mac. Try to run it in ZSH: ./setup.cmd (if you are in the tools directory) or ./tools/setup.cmd (from the root of the repo).

[dylan-sa]

Ah, you're absolutely right. User error on my part. 🙂

[dylan-sa]

Looking good to me. Tested on Windows and Mac.

[rjyounes]

@Jamie-SA Does this require a change to the documentation on setting up the project? Do you need to update the release note (you can include one note for the two issues).

[Jamie-SA]

Documentation is now updated.

[rjyounes]

@Jamie-SA I made a couple of tweaks to the documentation and tried to commit. I am getting the following error when the pre-commit runs:

line 32: return: can only `return' from a function or sourced script

Line 32 does indeed read "return 0"

I tried the following:

if [ ! ${rc} -eq 0 ] ; then
  return 1
else
  return 0
fi

But I get a similar error. I don't know why it accepts the "return 1" within the if statement.

I don't know if I'm doing something wrong or whether there's a problem with the pre-commit hook.

[Jamie-SA]

I guess some shells are more strict. I've pushed an update that will hopefully fix it.
The old version and the new version are working on my setup so I can't test it.

[rjyounes]

Your fix works, thanks!