Skip to content

Upgrade rdf-toolkit.jar to version 1.14.2 to suppress NamedIndividual assertions. Fixes #774. #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundle.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ variables:
name: "gist"
version: "X.x.x"
input: "."
rdf-toolkit: "{input}/tools/rdf-toolkit.jar"
rdf-toolkit: "{input}/tools/serializer/rdf-toolkit.jar"
output: "{name}{version}_webDownload"
tools:
- name: "serializer"
Expand Down
3 changes: 3 additions & 0 deletions docs/release_notes/pr788.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Patch Updates

* Removed NamedIndividual assertions on instances defined by gist, such as `gist:_second`. Issue [#774](https://github.com/semanticarts/gist/issues/774).
15 changes: 8 additions & 7 deletions tools/pre-commit → tools/serializer/pre-commit
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
# To enable this hook, save this file to the directory <your git clone root>/.git/hooks
#

# Customized by the git user
#export JAVA_HOME="/c/Program Files (x86)/Java/jre1.17.0_201"
# Customized by the git user - or set JAVA_HOME as persistent environment variable
# export JAVA_HOME="/c/Program Files (x86)/Java/jre1.17.0_201"

#
# Redirect all output generated by this script to stderr.
Expand Down Expand Up @@ -85,15 +85,15 @@ function findJava() {

function findSerializerJar() {

# DO NOT MODIFY! Only the version of rdf-toolkit.jar found in ${PWD}/tools/ should be used. Mixing versions may create bogus diffs.
RDF_TOOLKIT_JAR="$PWD/tools/rdf-toolkit.jar"
# DO NOT MODIFY! Only the version of rdf-toolkit.jar found in ${PWD}/tools/serializer should be used. Mixing versions may create bogus diffs.
RDF_TOOLKIT_JAR="$PWD/tools/serializer/rdf-toolkit.jar"

if [ -f "${RDF_TOOLKIT_JAR}" ] ; then
log "Found rdf-toolkit: ${RDF_TOOLKIT_JAR}"
return 0
fi

log_error "Could not find rdf-toolkit.jar in ${PWD}/tools/rdf-toolkit.jar. Please retrieve the file from the git repository. ONLY this version of the file should be used in order to prevent bogus diffs caused by mixing versions."
log_error "Could not find rdf-toolkit.jar in ${PWD}/tools/serializer. Please retrieve the file from the git repository. ONLY this version of the file should be used in order to prevent bogus diffs caused by mixing versions."

return 1
}
Expand Down Expand Up @@ -187,7 +187,8 @@ __log_config__
--target-format ${tfmt} \
--use-dtd-subset \
--string-data-typing explicit \
--inline-blank-nodes
--suppress-named-individuals \
--inline-blank-nodes
rc=$?
set +x

Expand Down Expand Up @@ -250,6 +251,6 @@ function main() {
main $*
rc=$?
if [ $rc -gt 0 ] ; then
log_error "Could not commit your files"
log_error "Could not commit your files."
fi
exit $rc
Binary file not shown.
7 changes: 3 additions & 4 deletions tools/serialize → tools/serializer/serialize.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ serialize_file() {
echo Skipping file $file.
return
fi
echo Reserializing $file into a standard format.
echo Serializing $file into a standard format.
tmp=$file.bak
cp $file $tmp
java -jar `dirname "$0"`/rdf-toolkit.jar -tfmt $format -sdt explicit -dtd -ibn -s $file -t $tmp
java -jar `dirname "$0"`/rdf-toolkit.jar -tfmt $format -sdt explicit -dtd -ibn -sni -s $file -t $tmp
mv $tmp $file
}

Expand All @@ -55,7 +55,6 @@ fi
if [ ${#args[@]} -eq 1 ] ; then
file=$1
if [ -f $file ] ; then
echo serializing $file
serialize_file $file
elif [ -d $file ]; then
# Remove a trailing slash (for printing filenames).
Expand All @@ -68,4 +67,4 @@ else
done
fi

echo Done!
echo Done serializing files!