Skip to content

GovernedGeoRegions and GovernmentOrganizations. Fixes #215. #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 24, 2022

Conversation

rjyounes
Copy link
Collaborator

@rjyounes rjyounes commented Mar 15, 2022

Applied serializer, merged in changes from develop, and made a few other changes to formal definitions and annotations.

@DanCarey404 Please review this draft PR before I turn it over to anyone else for review, as I've made some changes to both formal and textual definitions. I've added some skos:editorialNotes starting with "DAN" to flag a couple of issues for you. If necessary we can jump on a call to iron out details.

My first step was to run the serializer and merge in develop (commit ee5864b). The second commit involves some actual updates (dc2ade1). So the best way to view the changes that I've made is to compare those to commits.

@rjyounes rjyounes marked this pull request as draft March 15, 2022 18:50
@rjyounes rjyounes requested a review from DanCarey404 March 15, 2022 18:51
@rjyounes rjyounes changed the title Issue 215 country GovernedGeoRegions and GovernmentOrganizations. Fixes #215. Mar 15, 2022
Copy link
Contributor

@DanCarey404 DanCarey404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my responses below. But all your changes are okay with me.

@rjyounes rjyounes marked this pull request as ready for review March 24, 2022 17:59
@rjyounes rjyounes merged commit 3d7e081 into develop Mar 24, 2022
@rjyounes rjyounes deleted the Issue-215-country branch March 24, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants