-
Notifications
You must be signed in to change notification settings - Fork 21
GovernedGeoRegions and GovernmentOrganizations. Fixes #215. #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanCarey404
reviewed
Mar 24, 2022
DanCarey404
reviewed
Mar 24, 2022
DanCarey404
reviewed
Mar 24, 2022
DanCarey404
reviewed
Mar 24, 2022
DanCarey404
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my responses below. But all your changes are okay with me.
# Conflicts: # docs/ReleaseNotes.md # gistCore.ttl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied serializer, merged in changes from develop, and made a few other changes to formal definitions and annotations.
@DanCarey404 Please review this draft PR before I turn it over to anyone else for review, as I've made some changes to both formal and textual definitions. I've added some
skos:editorialNote
s starting with "DAN" to flag a couple of issues for you. If necessary we can jump on a call to iron out details.My first step was to run the serializer and merge in develop (commit ee5864b). The second commit involves some actual updates (dc2ade1). So the best way to view the changes that I've made is to compare those to commits.