Style guide updates for local name changes. Fixes #507. #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjyounes
requested review from
pwin,
uscholdm and
DanCarey404
and removed request for
pwin
sa-bpelakh
approved these changes
Sep 7, 2021
|
@sa-bpelakh Indeed, I had to check our title case policy to get that right! |
uscholdm
reviewed
Sep 13, 2021
| || `isCharacterizedBy`, not `characterizedBy` | | ||
| | Prefer an ordinary verb to "hasX" or "isX", even in a pair of inverses | `follows`, not `isPrecededBy`, even when inverse `precedes` exists | | ||
| | "At" rather than "on" for datetimes | `isRecordedAt`, not `isRecordedOn`. | | ||
| | Present tense only with minimal exceptions when the meaning is inherently in the past | `isRenderedOn`, not `wasRenderedOn`| |
There was a problem hiding this comment.
Give an example of a property that is inherently in the past.
There was a problem hiding this comment.
Sorry a bit late, just do this some other time, if at all.
There was a problem hiding this comment.
Good idea. I'll submit a new PR if you could just review it very quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.