-
Notifications
You must be signed in to change notification settings - Fork 21
fix geo route and remove geo segment #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MIssing release notes. We also talked about having a note that one could define a segment as a route with two points, but I think its too obvoius to say it. Though you might point it out in the release notes.
Are we planning this one for 13.1 or 14.0? If the former, we should deprecate |
We also can't normally rewrite the restrictions in a minor release; however, I think we can plausibly argue that both changes correct errors and are therefore patch updates. @philblackwood |
@uscholdm Our release notes are pretty bare bones, without justification or explanation. We link to the issue for that. |
@@ -0,0 +1 @@ | |||
Change the class equivalence statement for GeoRoute to say it is an ordered collection whose members are geo points. Also, GeoSegment is not necessary because it is just a geo route with two geo points. Therefore the class GeoSegment is being removed from gist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See Guidance on release notes in Contributing.md. Here's what I propose for this one:
### Minor Updates
- Deprecate `gist:GeoSegment`. Issue [#1165](https://github.com/semanticarts/gist/issues/1165).
### Patch Updates
- Correct errors in property restriction on `gist:GeoRoute`. Issue [#1165](https://github.com/semanticarts/gist/issues/1165).
skos:scopeNote "Each pair of consecutive GeoPoints in a GeoRoute is a GeoSegment."^^xsd:string ; | ||
. | ||
|
||
gist:GeoSegment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be deprecated, with an editorial note and addition of a new issue for 14.0.0
. See section "How to Deprecate" in Deprecation and Deletion Policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove GeoSegment, change GeoRoute class equivalence to say it is an ordered collection whose members are GeoPoints (old class equivalence incorrectly said it was an ordered collection with GeoSegments as parts).
Closes #1165