Skip to content

Added Determination class. #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Added Determination class. #1096

merged 5 commits into from
Jun 20, 2024

Conversation

uscholdm
Copy link
Contributor

@uscholdm uscholdm commented May 24, 2024

Closes #317.

I made the class a direct subclass of Event because a Determination need not be historical, it may be planned but unscheduled, or scheduled, in the process of happening, or already happened.

@uscholdm uscholdm requested review from rjyounes and marksem May 24, 2024 23:29
uscholdm and others added 2 commits May 31, 2024 10:35
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
@rjyounes rjyounes self-requested a review June 13, 2024 15:05
@@ -787,6 +787,14 @@ gist:DegreeOfCommitment
skos:prefLabel "Degree Of Commitment"^^xsd:string ;
.

gist:Determination
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the work done so far.

Q: Is there any property that would always be the case on a determination? Otherwise this is just a named class.

Copy link
Contributor Author

@uscholdm uscholdm Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marksem In real world terms, a determination

  • will always have an entity that does the determining (maybe inverse of produces) with the doer being a person, machine or program
  • will generally have an outcome (in the past I have used hasOutput for this)
  • will often have a method (min 0).

I'm ok with it just being a named class.

Copy link
Collaborator

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your proposed definition, so will approve this once you've added it and removed the scope note.

uscholdm

This comment was marked as off-topic.

@uscholdm uscholdm requested review from rjyounes and marksem June 14, 2024 17:44
@rjyounes
Copy link
Collaborator

@uscholdm I'm leaving this unmerged to consider whether we want to name it DeterminationEvent rather than Determination. Looks like it also needs to be updated with latest changes on develop.

@uscholdm
Copy link
Contributor Author

@uscholdm I'm leaving this unmerged to consider whether we want to name it DeterminationEvent rather than Determination. Looks like it also needs to be updated with latest changes on develop.

Lets leave it as it is. Its a subclass of Event.

@rjyounes rjyounes merged commit f89d202 into develop Jun 20, 2024
1 check passed
@rjyounes rjyounes deleted the Issue/317-determination-class branch June 20, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

New subclass of Event: Determination
3 participants