Skip to content

Removes sensor-related terms to fix issue 462 #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

turingtest37
Copy link
Contributor

Fixes #462

@turingtest37 turingtest37 added the impact: major Non-backward compatible (changes inferences; e.g., adding a restriction, domain, range) label Apr 25, 2024
Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • gist:MessageDefinition looks to be sensors-specific. I propose that we remove it unless there is justification for having it independently from sensors.
  • gist:directs looks to be sensors-specific. I propose that we remove it unless there is justification for having it independently from sensors.
  • gist:accepts looks to be sensors-specific. I propose that we remove it unless there is justification for having it independently from sensors.

@rjyounes
Copy link
Collaborator

rjyounes commented May 9, 2024

DECISION:

  • Remove MessageDefinition and directs
  • Rewrite definition of accepts as "Relates something to the types of inputs it accepts."

Copy link
Collaborator

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See decision in main comment thread.

@rjyounes
Copy link
Collaborator

@uscholdm to contact @turingtest37 to resolve questions about term deletions.

Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove MessageDefinition

# Conflicts:
#	ontologies/gistCore.ttl
@rjyounes rjyounes merged commit 7277981 into develop Jun 24, 2024
1 check passed
@rjyounes rjyounes deleted the remove-sensor-related-terms branch June 24, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: major Non-backward compatible (changes inferences; e.g., adding a restriction, domain, range)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Remove sensor-related terms
5 participants