Skip to content

Feature/new issue 831 add event specification #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 19, 2024

Conversation

uscholdm
Copy link
Contributor

@uscholdm uscholdm commented Apr 15, 2024

Fixes #831

  • Added EventSpecification.
  • Added and updated annotations for Specification.

OPEN QUESTION: there is now an incorrect subclass relationship.

Requirement: gist 12.0:

  • "A documented physical or functional need that a particular design, product, or process must be able to perform. Alternately, the obligation of a person or organization to behave in a certain way (i.e., drive on the right side of the road)."

Updated definition of Specification:

  • "One or more characteristics that specify what it means to be a particular type of thing such as a material, product, service or event. A specification is sufficiently precise to allow conformance of something to the specification to be tested."

A Specification is often not a need to be performed, so Specification cannot be a subclass of Requirement. It includes the idea of a law or regulation which is outside the scope of a specification.

Options include:

  1. Broaden the definition of Requirement to include Specification so the subclass relationship can remain. Easier said than done.
  2. Remove the class Requirement, it's never been use in my experience, if anyone want to represent a law or regulation, they can create a separate subclass.

@uscholdm uscholdm requested a review from rjyounes April 15, 2024 14:51
@rjyounes
Copy link
Collaborator

@uscholdm Is this PR ready for review? You've requested my review but it's still in draft state.

@uscholdm
Copy link
Contributor Author

@uscholdm Is this PR ready for review? You've requested my review but it's still in draft state.

An open question arose that I need your opinion on as to how to proceed. See first PR comment

@rjyounes
Copy link
Collaborator

rjyounes commented Apr 18, 2024

You could tweak the definition of Requirement to include the sense of Specification that includes EventSpecification. This makes perfect semantic sense to me: a certain weather event is required to have certain characteristics in order to be a hail storm and thus covered under insurance policy XYZ.

What I really don't like is that - as acknowledged in the current definition - Requirement merges two entirely separate concepts, presumably because they use the same English word - that's a trap we shouldn't fall into. Is this what you are suggesting? - to remove Requirement and promote Specification and Restriction to direct subclasses of Intention? Thus not combining the two different meanings of "requirement" into one class?

That might be the right thing to do, but that is too large a change to be rolled into this PR without group consideration. So for right now I would choose the first option I mentioned, and add a new issue for the second, to be considered for version 13.1.0.

@uscholdm
Copy link
Contributor Author

What I really don't like is that - as acknowledged in the current definition - Requirement merges two entirely separate concepts, presumably because they use the same English word - that's a trap we shouldn't fall into. Is this what you are suggesting? - to remove Requirement and promote Specification and Restriction to direct subclasses of Intention? Thus not combining the two different meanings of "requirement" into one class?

Yes exactly!

That might be the right thing to do, but that is too large a change to be rolled into this PR without group consideration.

agreed

So for right now I would choose the first option I mentioned, and add a new issue for the second, to be considered for version 13.1.0.

I tried a bunch of wording tweaks and failed to find something much better. I propose to just leave it for now and add an issue. It's only by chance I happened to notice anyway, and its only an annotation for a class that as far as I know rarely gets used.

@uscholdm uscholdm marked this pull request as ready for review April 19, 2024 02:07
Copy link
Collaborator

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've proposed some wording tweaks.

a owl:Class ;
rdfs:subClassOf gist:Specification ;
skos:definition "A characterization of an event that might happen."^^xsd:string ;
skos:example "A hail storm that is covered by an insurance policy. Someone defaults on a loan."^^xsd:string ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like:

An insurance company defines the characteristics of a weather event that must be satisfied for it to qualify as a hail storm covered in its homeowner's policy. Defaulting on a loan.

@rjyounes
Copy link
Collaborator

@uscholdm I've created issue #1087 for the Requirement proposal.

uscholdm and others added 2 commits April 19, 2024 10:43
Tweak some annotations.

Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
Copy link
Contributor Author

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjyounes This is ready for review again.

Copy link
Contributor Author

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I am being asked to review my own PR

@uscholdm uscholdm requested a review from rjyounes June 14, 2024 17:25
uscholdm and others added 2 commits June 14, 2024 14:57
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
@rjyounes rjyounes merged commit 3ea77fe into develop Jun 19, 2024
1 check passed
@rjyounes rjyounes deleted the feature/NEW-issue-831-add-EventSpecification branch June 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Define a class EventSpecification (was HypotheticalEvent)
2 participants