-
Notifications
You must be signed in to change notification settings - Fork 21
Feature/new issue 831 add event specification #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/new issue 831 add event specification #1077
Conversation
@uscholdm Is this PR ready for review? You've requested my review but it's still in draft state. |
An open question arose that I need your opinion on as to how to proceed. See first PR comment |
You could tweak the definition of What I really don't like is that - as acknowledged in the current definition - That might be the right thing to do, but that is too large a change to be rolled into this PR without group consideration. So for right now I would choose the first option I mentioned, and add a new issue for the second, to be considered for version 13.1.0. |
Yes exactly!
agreed
I tried a bunch of wording tweaks and failed to find something much better. I propose to just leave it for now and add an issue. It's only by chance I happened to notice anyway, and its only an annotation for a class that as far as I know rarely gets used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've proposed some wording tweaks.
ontologies/gistCore.ttl
Outdated
a owl:Class ; | ||
rdfs:subClassOf gist:Specification ; | ||
skos:definition "A characterization of an event that might happen."^^xsd:string ; | ||
skos:example "A hail storm that is covered by an insurance policy. Someone defaults on a loan."^^xsd:string ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about something like:
An insurance company defines the characteristics of a weather event that must be satisfied for it to qualify as a hail storm covered in its homeowner's policy. Defaulting on a loan.
Tweak some annotations. Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjyounes This is ready for review again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why I am being asked to review my own PR
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
Fixes #831
EventSpecification
.Specification
.OPEN QUESTION: there is now an incorrect subclass relationship.
Requirement
: gist 12.0:Updated definition of
Specification
:A Specification is often not a need to be performed, so Specification cannot be a subclass of Requirement. It includes the idea of a law or regulation which is outside the scope of a specification.
Options include: