Skip to content

post 531 actions - deprecating gist:symbolUnicode and gist:symbolHtml #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 13, 2024

Conversation

pwin
Copy link
Contributor

@pwin pwin commented Feb 12, 2024

Fixes #992.

@pwin pwin requested a review from uscholdm February 12, 2024 22:01
Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be removed, not deprecated. Here is why.

This is very confusing. I'm not exactly sure what is going on. @rjyounes It looks like the net effect of what we ended up doing was to rename unitSymbol to symbol and to remove unitSymbolUnicode and unitSymbolHtml, but we did it in two steps:

  1. First we 'renamed' unitSymbol, and unitSymbolUnicode and unitSymbolHtml, to unitSymbol, symbol and symbolUnicode and symbolHtml,. By rename, I mean we deprecated the original and created new properties.
  2. We removed symbolUnicode and symbolHtml

Normally we do not remove things except on a major release, but in this case we are not removing anything we added during this release, we are removing something we created during this release that we then removed.

@rjyounes rjyounes merged commit 34c32a8 into develop Feb 13, 2024
@rjyounes rjyounes deleted the pwin/post-531-actions.v2 branch February 13, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Remove symbolUnicode and symbolHtml? (post-531 implementation)
3 participants