Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial release #1

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Initial release #1

merged 1 commit into from
Dec 4, 2017

Conversation

pvdlg
Copy link
Member

@pvdlg pvdlg commented Dec 1, 2017

Plugin to:

  • Verify the git credential and plugin config
  • Optionally generate a CHANGELOG.md
  • Commit package.json and npm-shrinkwrap.json by default, and a configurable list of files
  • Allow to customize the commit message with variables
  • Create the git tag
  • Allow to use httpsor ssh (via a lengthy doc for the latter)
  • Allow to sign the release commit and tag with GPG

I think we could use it by default in semantic-release (after npm and before github) ?

I would also have to:

@pvdlg pvdlg requested a review from gr2m December 1, 2017 08:00
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t thoroughly review the whole pull request, but there is no reason not to release it either, as it’s entirely new. You put some serious work into this, I think lots of folks will love that there is now a way that allows them to have a version in their package.json file that gets updated by semantic-release, and a way to have a changelog file :)

I wouldn’t like to make this a default in semantic-release in general, but it’s great to have an official plugin for folks who prefer that 👍

README.md Outdated
### Git Repository authentication

The `Git` authentication configuration is **required** and can be set either:
- with the [`GIT_CREDENTIALS` environment variable](#environment-variable) for accessing the repository via [https](https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols#_the_http_protocols)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#environment-variable should be #environment-variables

@pvdlg pvdlg force-pushed the initial-release branch 12 times, most recently from 83f8d17 to 2f81802 Compare December 3, 2017 23:10
@pvdlg pvdlg merged commit 8ba9c68 into master Dec 4, 2017
@pvdlg pvdlg deleted the initial-release branch December 4, 2017 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants