Skip to content

Commit analyzer fails if there are commits without proper header #224

@felixcolaci

Description

@felixcolaci

Hi there,

we encountered an error where the commit-analyzer - when used inside a github action - fails if there are commits without a proper header. This sometimes happens due to automagic merging of pull requests in our repository.

[8:43:29 AM] [semantic-release] › ✖  An error occurred while running semantic-release: TypeError: Cannot read property 'trim' of undefined
    at parser (/action/node_modules/conventional-commits-parser/lib/parser.js:150:20)
    at sync (/action/node_modules/conventional-commits-parser/index.js:97:10)
    at /action/node_modules/@semantic-release/commit-analyzer/index.js:42:90
    at Array.map (<anonymous>)
    at analyzeCommits (/action/node_modules/@semantic-release/commit-analyzer/index.js:42:8)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async validator (/action/node_modules/semantic-release/lib/plugins/normalize.js:34:24)
    at async /action/node_modules/semantic-release/lib/plugins/pipeline.js:37:34
    at async /action/node_modules/semantic-release/lib/plugins/pipeline.js:31:3
    at async Object.pluginsConf.<computed> [as analyzeCommits] (/action/node_modules/semantic-release/lib/plugins/index.js:80:11) {
  pluginName: '@semantic-release/commit-analyzer'
}
::error::TypeError: Cannot read property 'trim' of undefined

This is not a problem with this repository itself but with the upstream project conventional-changelog/conventional-commits-parser. In the meantime there has been a fix for this problem so it would be great if we could update the dependency in this repository.
I bumbed the version locally on my machine, ran unit tests and everything seems fine so far. I would be happy to provide that tiny PR.

Best
Felix

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions