Critical review #73
Merged
Critical review #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@NicholasDanks how about not exporting the *_evaluate_measurement_model functions for now, and just testing them instead? That way TravisCI can check them instead. Can the tests assert the behavior of non-exported functions? |
Collaborator
Author
|
@soumyaray yes I can not export them and test. Travis is failing because I didn't document those exported functions. I haven't written tests yet. I'm still brainstorming the best way to deliver the evaluation data to users. In return objects or big screen dumps from summary. |
Contributor
|
let's not export the measurement evaluation functions; let's test them instead, then push commits and see if Travis CI tests pass. If they do, please merge into develop. We can work on their summaries/printing in another branch. |
…d boot_evaluate_measurement_model(). revert seminr-ecsi.R. Addresses Issue #73
… boot_evaluate_measurement_model(). All tests pass and R CMD CHECK passes. READY TO MERGE
NicholasDanks
added a commit
that referenced
this pull request
Jul 16, 2018
* changed all references to factor to construct and changed name of return item from estimate_pls() fscores to construct_scores * renamed function path_coef to estimate_path_coef to eliminate duplicate variable assignment * Added a TRAVIS-CI badge * Added Juan as Author and renamed fscores to construct_scores * Altered summary return object to return composite scores only modified library.R to create return_only_composite_scores() function and summary.R to return only composite (not common-factor) scores. * Added a note in vignette to describe summary reporting of composite scores and common-factor-indeterminacy. * Bump DESCRIPTION attributes and minor fixes in vignette * Added cran-comments.md file - added to Rbuildignore * Addresses Issue #58 bug * Addressing New Feature #60 VIF * Addresse Issue #57 Add logo to Vignette and Readme * Changed vignette from pdf to html * Changed V0.4.0 to V0.4.1 R CMD CHeck 1 warning * Removed inst/doc/SEMinR.pdf due to R CMD CHECK warning. CMD CHECK all clear * extract a generic vif function (#63) * DRY and extract VIF functions to new files; update summary() * Tests for VIF results * Addresses a minor bug in VIF test setup. Changed test code, not VIF method. * Addresses Issue #64: remove SEMinR title from the Readme. * Documented VIF report in Vignette. Issue #60 * Addresses Issue #64 : duplicate rhoA and rho_A function. removed rhoA and changed documentation for rho_A. changed tests for rho_A to match this and fixture: rho2.csv. Addresses Issue #64 :Linked Travis badge to develop branch. * Addresses Issue #64 change ltVariables to constructs, change latent to construct and latents to constructs. Throughout. All tests pass. * Issue #64 change documentation to reflect no use of the word latent. * # created method to calculate saturated model SRMR and estimmated model SRMR. NOTE The results do not agree with either SmrtPLS or ADANCO who do not agree either. * Addresses issue #65 bug in vif. I fixed the bug, checked handling of construct names with a space throughout and added tests in test-structure.r for constructs with (1) numeric name, (2) name including a space. The tests check if (1) regular pls, (2) PLSc, (3) interactions work with either construct name case. All tests pass. * Addresses issue #64 change interaction names from construct.construct to construct*construct * Addresses issue #64. Changed names of interactions: construct.construct to construct*construct. all tests passing and CMD CHECK passing * Issue #64 Again... Finally passed all problems with item*item change. Tests pass, CMD CHECK passes * Addresses issue #67, handling errors in the bootstrap model method and ensuring the cluster is stopped and appropriate error messages are printed. * Cleaning up the code issue #67 * Issue #67 refining output to reflect error or warning, or success * Added SRMR code and reverted demo/seminr-ecsi.R to original format. * Critical review (#73) * Addresses issue #71 adding metrics for measurement model * Addresses #69 - Add bootstrap functionality for weights, loadings and HTMT * Addresses issue #72 added bootstrap p and t values for weights and HTMT * Bug fixing and choosing not to export evaluate_measurement_model() and boot_evaluate_measurement_model(). revert seminr-ecsi.R. Addresses Issue #73 * Addresses Issue #73 - R CMD CHECK failing. * Addresses issue #69 #73 added tests for bootstrap weights, loadings and HTMT. * Addresses issue #73. Added tests for evaluate_measurement_model() and boot_evaluate_measurement_model(). All tests pass and R CMD CHECK passes. * Increased tolerance on tests for bootstrapped metrics due to instability at low reps.#73 * Bumped version, updated cran comments, rebuilt vignette in prep for CRAN re-submission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
created two methods
evaluate_measurement_model()
boot_evaluate_measurement_model()
These two methods will be incorporated into summary()
added bootstrap for weights, loadings and HTMT
Still needs: