Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parser to be compatible with new ua-parser #90

Merged
merged 3 commits into from
Apr 7, 2019
Merged

Fixed parser to be compatible with new ua-parser #90

merged 3 commits into from
Apr 7, 2019

Conversation

IMDagger
Copy link
Contributor

@IMDagger IMDagger commented Jan 4, 2019

"RT" and "ME" are stored in version now

@IMDagger
Copy link
Contributor Author

IMDagger commented Jan 4, 2019

didn't touch travis configuration, but I guess 3.3 (because pip doesn't work) should be removed from the list to pass checks

@stefanfoulis
Copy link

I can confirm this fix works as expected for detecting Windows 8 touch devices.

@selwin
Copy link
Owner

selwin commented Mar 29, 2019

Sorry for the delayed response.

I have just updated travis.yml to support Python 2.7 and Python >= 3.4. Could you please merge the changes to this branch to see if the tests pass?

If we can get this in, I'll cut a release soon.

@IMDagger
Copy link
Contributor Author

@selwin TravisCI said "3.7 is not installed; attempting download" this time and building was failed for 3.7 case (as for 3.3 previous time)

@selwin
Copy link
Owner

selwin commented Mar 30, 2019

We should omit Python 3.7 then, let’s just test up to Python 3.6.

@IMDagger
Copy link
Contributor Author

@selwin I suppose we can try this official workaround for 3.7

@selwin
Copy link
Owner

selwin commented Mar 31, 2019 via email

@IMDagger
Copy link
Contributor Author

IMDagger commented Apr 5, 2019

Sure, let me know if it works :) Best, Selwin

On 31 Mar 2019 03.48 +0700, Alex Moiseenko @.***>, wrote: @selwin I suppose we can try this official workaround for 3.7 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

I just added "dist: xenial" and 3.7 works now

@selwin selwin merged commit 87936f2 into selwin:master Apr 7, 2019
@selwin
Copy link
Owner

selwin commented Apr 7, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants