Skip to content

__str__() method for convenience pretty string #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 31, 2014

Conversation

loisaidasam
Copy link
Contributor

Complete with unit tests, version bump, and documentation updates

@selwin
Copy link
Owner

selwin commented Jul 14, 2014

@loisaidasam sorry, for some reason I missed your PR. I like these additions, could you please swap the order of appearance to from <DEVICE> / <OS> / <BROWSER> to <BROWSER> / <OS> / <DEVICE>?

Thanks!

@selwin
Copy link
Owner

selwin commented Jul 14, 2014

Should we also add a __unicode__ method as well?

@loisaidasam
Copy link
Contributor Author

Hey @selwin sorry for the delay. I added a __unicode__() method, but I'm hesitant to switch the order of appearance - can you provide a reason that you'd like them in that order? My natural instinct was to preserve the hierarchical order from largest to smallest.

@selwin
Copy link
Owner

selwin commented Aug 13, 2014

@loisaidasam no worries :). Because browser is the most important component, user agent capabilities are mostly dependent on browser type rather than what device they run on. Of course, use cases may vary, I could also be biased because I'm first and foremost a web developer ;)

@selwin
Copy link
Owner

selwin commented Aug 13, 2014

@loisaidasam could you also try to merge master into your branch? This PR no longer merges cleanly I'm afraid :(

@loisaidasam
Copy link
Contributor Author

Should be good to go! Thanks @selwin

selwin added a commit that referenced this pull request Aug 31, 2014
__str__() method for convenience pretty string
@selwin selwin merged commit 3dede6f into selwin:master Aug 31, 2014
@selwin
Copy link
Owner

selwin commented Aug 31, 2014

Merged, thanks!

@loisaidasam
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants