-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various changes for usability #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ehfd
commented
Oct 4, 2022
•
edited
Loading
edited
- Remove tkinter dependency, not needed after all
- Allow empty username for basic authentication if there is no $USER
- Fix docs and base example image behavior
- Ensure that libvpx is explicitly installed and supported
- Change default from nvh264enc to x264enc so the project will start up by default without a NVIDIA GPU
- Remove CPU thread restriction with vpx and x264, encoder will automatically determine number of threads (it was better, at least for me)
- Fix Keyboard keys < and > do not work #6.
#6 fixed with minimal side effects. |
Closes #6. |
Closed
16 tasks
Note that we would want GStreamer 1.21.1 before a release when this is merged. |
Ready for review @danisla |
Fixes a lot of #40 but we'll put the rest in another PR. |
@danisla This can be merged. If I have something else I will raise another issue. |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.