Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite documentation and improve usability #51

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Rewrite documentation and improve usability #51

merged 4 commits into from
Sep 21, 2022

Conversation

ehfd
Copy link
Member

@ehfd ehfd commented Sep 12, 2022

This PR is mainly a rewrite of the documentation README.md, but with two subtle code changes.

  1. Instead of patching GStreamer for rtx-time, use regex replace within gstwebrtc_app.py, just like the Firefox fix.
  2. gst-env prepares the environments to an arbitrary GStreamer directory with GSTREAMER_PATH.

@danisla @xhejtman Please provide feedback. Edits have been allowed for maintainers.

@danisla Please enable Discussions for this repository before merging. Done.

@ehfd
Copy link
Member Author

ehfd commented Sep 14, 2022

Solves most of #40, but do not close the issue.

@ehfd
Copy link
Member Author

ehfd commented Sep 16, 2022

@danisla Requesting review...

@ehfd
Copy link
Member Author

ehfd commented Sep 16, 2022

For reference, CODE_OF_CONDUCT.md is basically Github's template.

@danisla danisla self-requested a review September 21, 2022 15:28
@danisla
Copy link
Member

danisla commented Sep 21, 2022

LGTM and I have enabled Discussions.

@danisla danisla merged commit 997a9e6 into selkies-project:master Sep 21, 2022
@ehfd
Copy link
Member Author

ehfd commented Sep 21, 2022

FINALLY.

@ehfd ehfd deleted the documentation branch September 21, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants