System optimizations #453
System optimizations #453
Conversation
reduced camera loading time
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #453 +/- ##
===========================================
- Coverage 94.82% 94.67% -0.15%
===========================================
Files 60 70 +10
Lines 7434 7575 +141
===========================================
+ Hits 7049 7172 +123
- Misses 385 403 +18 ☔ View full report in Codecov by Sentry. |
|
Translation refactor reduces total firmware size in ~5% and increases free RAM at boot in ~3% |
clean tests
playoff word was being detected as PMofN
|
I've visually reviewed the code changes in 30 files here. Much of this I've tested on Amigo (whose camera works fine), but none since this pr was readied last week, nor any of the changes since "translation optimizations". Currently I'm having personal hw problems and cannot build for my amigo but I expect this to be resolved soon and will edit this message when done. |
|
Thank you Jean! I also ended up adding new Sparrow's SD message signing feature here too, and this will require a few more tests to be written. |
|
Message signing via qrcode and via sdcard with sparrow 2.0.0 worked fine for me. |
| try: | ||
| parts = derivation_path.split("/") | ||
| return parts[0] == "m" and all( | ||
| p.endswith("'") or p.endswith("h") or p.isdigit() for p in parts[1:] |
There was a problem hiding this comment.
note: check that derivation_path.lower() happens prior to this... or add "H"
| ) | ||
| self.ctx.input.wait_for_button() | ||
| return sig | ||
| script_from_deriv = int(parts[1].strip("'").strip("h")) |
tolerate "H" for hard derivation in message signing
Description
Problem: A damaged camera currently renders devices unusable.
Solution: This PR addresses the issue by allowing Krux to operate without a functioning camera and includes some performance optimizations.
Changes:
Other Optimizations
What is the purpose of this pull request?