#717 Started implementing GitlabIssues.

[criske]

closes #717

[charlesmike]

@criske thank you for your Pull Request. I'll assign someone to review it soon.

[criske]

@amihaiemil On my end the test for this part was failling with
java.lang.NumberFormatException: For input string: "8,00" due to using comma separator imposed by Locale, most likely. So I've changed it to use BigDecimals only.

[charlesmike]

@amihaiemil please review this Pull Request. Deadline (when it should be merged or closed) is 2020-11-29T10:51:51.799504.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

[criske]

@amihaiemil we're using a regexed split cause
Issue json is using #

"references": {
    "short": "#1",
    "relative": "#1",
    "full": "my-group/my-project#1"
  }

Pull request (merge request) is using !

"references": {
    "short": "!1",
    "relative": "!1",
    "full": "my-group/my-project!1"
  }

[criske]

I've opted for iid (relative id to project) insted of id (global id) because Issues and Pull Requests are using iid in their url:
GET /projects/:id/issues/:issue_iid
GET /projects/:id/merge_requests/:merge_request_iid

[amihaiemil]

@rultor merge it please

[rultor]

@rultor merge it please

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge it please

@amihaiemil @criske Oops, I failed. You can see the full log here (spent 3min)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 27283
+ echo '1.69.1 839260fab'
1.69.1 839260fab
+ date
Fri Nov 27 09:30:52 CET 2020
+ uptime
 09:30:52 up 60 days, 18:36,  0 users,  load average: 0.06, 0.01, 0.00
+ ff=default
+ image=g4s8/rultor-jdk11:alpine3.10
+ rebase=false
+ head_branch=master
+ pull_title='#717 Started implementing GitlabIssues.'
+ author=amihaiemil
+ directory=
+ head=git@github.com:self-xdsd/self-core.git
+ pull_id=718
+ fork=git@github.com:criske/self-core.git
+ fork_branch=issue717
+ squash=false
+ vars=('--env=JAVA_HOME=/usr/lib/jvm/java-11-openjdk' '--env=head=git@github.com:self-xdsd/self-core.git' '--env=pull_id=718' '--env=fork=git@github.com:criske/self-core.git' '--env=fork_branch=issue717' '--env=head_branch=master' '--env=pull_title=#717 Started implementing GitlabIssues.' '--env=author=amihaiemil' '--env=scripts=( '\''export '\''\'\'''\''JAVA_HOME=/usr/lib/jvm/java-11-openjdk'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head=git@github.com:self-xdsd/self-core.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=718'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:criske/self-core.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=issue717'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=#717 Started implementing GitlabIssues.'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=amihaiemil'\''\'\'''\'''\'' '\'';'\'' '\''mvn clean install -Pcheckstyle,itcases'\'' '\'';'\'' )')
+ scripts=('export '\''JAVA_HOME=/usr/lib/jvm/java-11-openjdk'\''' ';' 'export '\''head=git@github.com:self-xdsd/self-core.git'\''' ';' 'export '\''pull_id=718'\''' ';' 'export '\''fork=git@github.com:criske/self-core.git'\''' ';' 'export '\''fork_branch=issue717'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#717 Started implementing GitlabIssues.'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle,itcases' ';')
+ container=self-xdsd_self-core_718
+ as_root=false
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:self-xdsd/self-core.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''JAVA_HOME=/usr/lib/jvm/java-11-openjdk'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''JAVA_HOME=/usr/lib/jvm/java-11-openjdk'\''' ';' 'export '\''head=git@github.com:self-xdsd/self-core.git'\''' ';' 'export '\''pull_id=718'\''' ';' 'export '\''fork=git@github.com:criske/self-core.git'\''' ';' 'export '\''fork_branch=issue717'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#717 Started implementing GitlabIssues.'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle,itcases' ';'
+ sensitive=()
+ gpgconf --reload gpg-agent
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
gpg: keyserver timed out
gpg: keyserver receive failed: keyserver error
'cid' file is absent, container wasn't started correctly

[amihaiemil]

@criske some puzzle is not correct, can you fix it pls? :D

[charlesmike]

@amihaiemil thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.