Skip to content

Commit c08e834

Browse files
authored
Docker: Enable SE_NODE_ENABLE_MANAGED_DOWNLOADS in particular components (#2870)
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
1 parent dd40b80 commit c08e834

File tree

8 files changed

+14
-8
lines changed

8 files changed

+14
-8
lines changed

NodeBase/Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ ENV LANG_WHICH=${LANG_WHICH} \
5656
SE_OFFLINE="true" \
5757
SE_NODE_BROWSER_VERSION="stable" \
5858
SE_NODE_PLATFORM_NAME="Linux" \
59-
SE_NODE_ENABLE_MANAGED_DOWNLOADS="true" \
6059
#============================
6160
# Some configuration options
6261
#============================

NodeChrome/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,4 +84,5 @@ RUN echo "chrome" > /opt/selenium/browser_name
8484
RUN google-chrome --version | awk '{print $3}' > /opt/selenium/browser_version
8585
RUN echo "\"goog:chromeOptions\": {\"binary\": \"/usr/bin/google-chrome\"}" > /opt/selenium/browser_binary_location
8686

87-
ENV SE_OTEL_SERVICE_NAME="selenium-node-chrome"
87+
ENV SE_OTEL_SERVICE_NAME="selenium-node-chrome" \
88+
SE_NODE_ENABLE_MANAGED_DOWNLOADS="true"

NodeChromium/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,5 @@ RUN echo "chrome" > /opt/selenium/browser_name
4747
RUN chromium --version | awk '{print $2}' > /opt/selenium/browser_version
4848
RUN echo "\"goog:chromeOptions\": {\"binary\": \"/usr/bin/chromium\"}" > /opt/selenium/browser_binary_location
4949

50-
ENV SE_OTEL_SERVICE_NAME="selenium-node-chromium"
50+
ENV SE_OTEL_SERVICE_NAME="selenium-node-chromium" \
51+
SE_NODE_ENABLE_MANAGED_DOWNLOADS="true"

NodeDocker/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,5 @@ COPY selenium-grid-docker.conf /etc/supervisor/conf.d/
3232
ENV SE_OTEL_SERVICE_NAME="selenium-node-docker" \
3333
SE_EVENT_BUS_PUBLISH_PORT="4442" \
3434
SE_EVENT_BUS_SUBSCRIBE_PORT="4443" \
35-
SE_NODE_DOCKER_CONFIG_FILENAME="docker.toml"
35+
SE_NODE_DOCKER_CONFIG_FILENAME="docker.toml" \
36+
SE_NODE_ENABLE_MANAGED_DOWNLOADS="true"

NodeEdge/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,4 +71,5 @@ RUN echo "MicrosoftEdge" > /opt/selenium/browser_name
7171
RUN microsoft-edge --version | awk '{print $3}' > /opt/selenium/browser_version
7272
RUN echo "\"ms:edgeOptions\": {\"binary\": \"/usr/bin/microsoft-edge\"}" > /opt/selenium/browser_binary_location
7373

74-
ENV SE_OTEL_SERVICE_NAME="selenium-node-edge"
74+
ENV SE_OTEL_SERVICE_NAME="selenium-node-edge" \
75+
SE_NODE_ENABLE_MANAGED_DOWNLOADS="true"

NodeFirefox/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,4 +89,5 @@ RUN echo "firefox" > /opt/selenium/browser_name \
8989
&& firefox --version | awk '{print $3}' > /opt/selenium/browser_version \
9090
&& echo "\"moz:firefoxOptions\": {\"binary\": \"/usr/bin/firefox\"}" > /opt/selenium/browser_binary_location
9191

92-
ENV SE_OTEL_SERVICE_NAME="selenium-node-firefox"
92+
ENV SE_OTEL_SERVICE_NAME="selenium-node-firefox" \
93+
SE_NODE_ENABLE_MANAGED_DOWNLOADS="true"

Standalone/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ ENV SE_SESSION_REQUEST_TIMEOUT="300" \
2929
# Boolean value, maps "--relax-checks"
3030
SE_RELAX_CHECKS="true" \
3131
SE_REJECT_UNSUPPORTED_CAPS="true" \
32-
SE_OTEL_SERVICE_NAME="selenium-standalone"
32+
SE_OTEL_SERVICE_NAME="selenium-standalone" \
33+
SE_NODE_ENABLE_MANAGED_DOWNLOADS="true"
3334

3435
EXPOSE 4444

StandaloneDocker/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,5 @@ ENV SE_SESSION_REQUEST_TIMEOUT="300" \
2020
SE_SESSION_RETRY_INTERVAL="15" \
2121
# Boolean value, maps "--relax-checks"
2222
SE_RELAX_CHECKS="true" \
23-
SE_OTEL_SERVICE_NAME="selenium-standalone-docker"
23+
SE_OTEL_SERVICE_NAME="selenium-standalone-docker" \
24+
SE_NODE_ENABLE_MANAGED_DOWNLOADS="true"

0 commit comments

Comments
 (0)