Docker: Enable SE_NODE_ENABLE_MANAGED_DOWNLOADS in particular components

[VietND96]

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Enhancement

---

Description

• Move SE_NODE_ENABLE_MANAGED_DOWNLOADS from base to specific components

• Enable managed downloads for Chrome, Chromium, Edge, Firefox nodes

• Enable managed downloads for Docker and Standalone components

---

Changes diagram

flowchart LR
  NodeBase["NodeBase/Dockerfile"] -- "Remove global setting" --> Components["Browser Components"]
  Components -- "Add specific setting" --> Chrome["NodeChrome"]
  Components -- "Add specific setting" --> Chromium["NodeChromium"]
  Components -- "Add specific setting" --> Edge["NodeEdge"]
  Components -- "Add specific setting" --> Firefox["NodeFirefox"]
  Components -- "Add specific setting" --> Docker["NodeDocker"]
  Components -- "Add specific setting" --> Standalone["Standalone"]

Loading

---

Changes walkthrough 📝

Relevant files

Configuration changes

8 files Dockerfile Remove global SE_NODE_ENABLE_MANAGED_DOWNLOADS setting      +0/-1      Dockerfile Add SE_NODE_ENABLE_MANAGED_DOWNLOADS environment variable +2/-1      Dockerfile Add SE_NODE_ENABLE_MANAGED_DOWNLOADS environment variable +2/-1      Dockerfile Add SE_NODE_ENABLE_MANAGED_DOWNLOADS environment variable +2/-1      Dockerfile Add SE_NODE_ENABLE_MANAGED_DOWNLOADS environment variable +2/-1      Dockerfile Add SE_NODE_ENABLE_MANAGED_DOWNLOADS environment variable +2/-1      Dockerfile Add SE_NODE_ENABLE_MANAGED_DOWNLOADS environment variable +2/-1      Dockerfile Add SE_NODE_ENABLE_MANAGED_DOWNLOADS environment variable +2/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Configuration Impact Removing SE_NODE_ENABLE_MANAGED_DOWNLOADS from the base image may affect components that inherit from NodeBase but don't explicitly set this variable. Verify that all components that need managed downloads are properly configured. SE_NODE_REGISTER_SHUTDOWN_ON_FAILURE="true" \ SE_NODE_CONNECTION_LIMIT_PER_SESSION="10" \ SE_OTEL_SERVICE_NAME="selenium-node" \ SE_NODE_RELAY_ONLY="true" \ # Setting Selenium Manager to work offline SE_OFFLINE="true" \ SE_NODE_BROWSER_VERSION="stable" \ SE_NODE_PLATFORM_NAME="Linux" \ #============================ # Some configuration options #============================ SE_RECORD_VIDEO=false \

[qodo-merge-pro]

PR Code Suggestions ✨

No code suggestions found for the PR.