Skip to content
This repository was archived by the owner on Jun 22, 2024. It is now read-only.

Conversation

fhoeben
Copy link

@fhoeben fhoeben commented Dec 19, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @fhoeben!

@diemol diemol merged commit 2fa3d3b into seleniumhq-community:seleniarm_add_chromium_arm64_circle Dec 19, 2023
@fhoeben fhoeben deleted the seleniarm_add_chromium_arm64_circle_fix1 branch December 19, 2023 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants