-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
adding silent parameter to clearOptions #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks bubb-rubb. Why isn't this still merged? Really need this. |
+1 |
+1 |
+1 need this in my life! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much needed
+1, This is really much needed @joallard @brianreavis merging this will be very helpful. |
For now, adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reviews and +1s. Here are my requested changes:
- Document parameter in
docs/
- Document parameter in method comments
- Rebase commit on top of master
If the original PR author is not available, I'd accept an alternative PR with credit to @bubb-rubb.
superseded via PR #1553 |
this commit fixes #832