Skip to content

adding silent parameter to clearOptions #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bubb-rubb
Copy link
Contributor

this commit fixes #832

@dattz
Copy link

dattz commented Apr 6, 2017

Thanks bubb-rubb.

Why isn't this still merged? Really need this.

@millerbennett
Copy link

+1

@doerig
Copy link

doerig commented Aug 22, 2017

+1

@mcfoton
Copy link

mcfoton commented Mar 6, 2018

+1 need this in my life!

Copy link

@NitsanBaleli NitsanBaleli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much needed

@nmnandakishore
Copy link

nmnandakishore commented May 30, 2018

+1, This is really much needed @joallard @brianreavis merging this will be very helpful.

@nmnandakishore
Copy link

For now, adding clear(true); before clearOptions(); does the job if we don't want the onChange event to be fired.

Copy link
Member

@joallard joallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reviews and +1s. Here are my requested changes:

  • Document parameter in docs/
  • Document parameter in method comments
  • Rebase commit on top of master

If the original PR author is not available, I'd accept an alternative PR with credit to @bubb-rubb.

@risadams
Copy link
Contributor

risadams commented Nov 4, 2020

superseded via PR #1553

@risadams risadams closed this Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clearOptions() silent option
9 participants