Added fix to not add "required" attr unless field is actually required. #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the HTML5 spec, the
required
attribute is a boolean attribute. Just having it present (even if it's value is "false") makes the element required. Most browsers will still work with the attribute set to false, but I've made a very small change to not add the attr at all if the original select does not have therequired
attribute. This should hopefully future-proof it in case browser's change their mind. I've only noticed IE8 marking the field as invalid even withrequired="false"
.I've added some basic tests along with it, but if you need me to make them more robust, let me know.