Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-pad dropdown text to prevent overlap with arrow #2087

Closed
wants to merge 3 commits into from

Conversation

Mkranj
Copy link

@Mkranj Mkranj commented Mar 14, 2024

When the text inside a dropdown is quite long, it is possible for it to obscure the arrow that indicates this is a dropdown menu. This can look somewhat unpolished.

I included a padding-right statement to preserve the bit of space that the arrow occupies.
Below is an example of a dropdown before and after this change.

selectize_rpad_arrow

@databyte
Copy link
Collaborator

I can't quickly confirm this doesn't have any other side effects due to the broad selector used (> *). Also there's support for right-to-left languages such as Korean and Chinese that I'm sure doesn't assume the padding should always to be on the right.

Copy link
Contributor

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants