Fix FF and IE tabbing/blur issues. #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topaxi
commented
Dec 18, 2017
| // Do not trigger blur while inside a blur event, | ||
| // this fixes some weird tabbing behavior in FF and IE. | ||
| // See #1164 | ||
| if (self.ignoreFocus) { |
There was a problem hiding this comment.
I've used ignoreFocus as it's set in the onBlur method, maybe I should use a different, new, boolean flag?
There was a problem hiding this comment.
I'm not actively developing the project, I'll have to take your word for it
|
Will these changes be available soon? We could use them too in our current project. Cheers |
|
If you could both validate whether the fix is suitable and ready, I'd merge. |
|
It's seems that this fix is OK. Let's merge :) 🚀 |
|
This broke the |
joallard
added a commit
that referenced
this pull request
May 25, 2018
Fixes failing test after regression in #1353, while trying to preserve its functionality.
michael-maltsev
pushed a commit
to michael-maltsev/selectize.js
that referenced
this pull request
Aug 28, 2018
Fix FF and IE tabbing/blur issues.
michael-maltsev
pushed a commit
to michael-maltsev/selectize.js
that referenced
this pull request
Aug 28, 2018
Fixes failing test after regression in selectize#1353, while trying to preserve its functionality.
anandphulwani
pushed a commit
to anandphulwani/selectize.js
that referenced
this pull request
Jan 17, 2021
Rectified selectize#1164 issue considered previously fixed, done with the pull selectize#1353 and pushed commit michael-maltsev@f6e9faa
risadams
pushed a commit
that referenced
this pull request
Jan 17, 2021
Rectified #1164 issue considered previously fixed, done with the pull #1353 and pushed commit michael-maltsev@f6e9faa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1164