Remove keypress checks to fix autogrow jitter for some characters. #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use input event to avoid printable character checks. Instead, just check the field value after something's been entered. Addresses issue where common, non-(a-z0-9) characters jogged left until a key was released.
|
Quite elegant. Since this breaks IE8/9, let's classify this as a breaking change and schedule it for 1.0. If we can integrate a polyfill, I'd consider moving it forward. |
|
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue where common, non-(a-z/0-9) characters jogged left until a key was released.
#809
This PR uses the input event to avoid printable character checks entirely. Instead, just check the field value after something's been entered/removed/pasted/etc.
This breaks IE8/9 compatibility, so a polyfill may be required. This may not be acceptable, depending on long-term roadmap.
Updated demo page here: https://billiam.github.io/selectize.js