Skip to content

C style cast cleanup. #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025
Merged

C style cast cleanup. #1846

merged 4 commits into from
Jun 12, 2025

Conversation

Dimi1010
Copy link
Collaborator

@Dimi1010 Dimi1010 commented Jun 7, 2025

  • Replaced or removed C style casts with C++ casts.
  • Replaced iterator based for loops with range based for loops.

Copy link

codecov bot commented Jun 7, 2025

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.99%. Comparing base (147f901) to head (97c71df).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
Pcap++/src/RawSocketDevice.cpp 84.61% 0 Missing and 2 partials ⚠️
Pcap++/src/PcapFileDevice.cpp 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1846      +/-   ##
==========================================
- Coverage   83.00%   82.99%   -0.01%     
==========================================
  Files         284      284              
  Lines       49006    49007       +1     
  Branches    10574    10579       +5     
==========================================
- Hits        40675    40673       -2     
- Misses       7216     7222       +6     
+ Partials     1115     1112       -3     
Flag Coverage Δ
alpine320 75.09% <84.21%> (+0.01%) ⬆️
fedora42 75.18% <84.21%> (-0.02%) ⬇️
macos-13 80.52% <78.57%> (-0.01%) ⬇️
macos-14 80.52% <78.57%> (-0.01%) ⬇️
macos-15 80.50% <78.57%> (-0.01%) ⬇️
mingw32 71.34% <85.71%> (-0.04%) ⬇️
mingw64 71.34% <85.71%> (-0.02%) ⬇️
npcap 84.91% <88.23%> (-0.09%) ⬇️
rhel94 74.95% <84.21%> (+<0.01%) ⬆️
ubuntu2004 58.64% <85.00%> (-0.03%) ⬇️
ubuntu2004-zstd 58.78% <85.00%> (-0.01%) ⬇️
ubuntu2204 74.87% <84.21%> (-0.03%) ⬇️
ubuntu2204-icpx 61.48% <82.60%> (-0.01%) ⬇️
ubuntu2404 75.14% <84.21%> (+<0.01%) ⬆️
ubuntu2404-arm64 75.10% <84.21%> (-0.03%) ⬇️
unittest 82.99% <88.46%> (-0.01%) ⬇️
windows-2019 85.00% <88.23%> (-0.01%) ⬇️
windows-2022 85.01% <88.23%> (-0.01%) ⬇️
winpcap 85.16% <88.23%> (ø)
xdp 50.56% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@tigercosmos tigercosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@Dimi1010 Dimi1010 marked this pull request as ready for review June 7, 2025 19:50
@Dimi1010 Dimi1010 requested a review from seladb as a code owner June 7, 2025 19:50
@Dimi1010 Dimi1010 merged commit 1674286 into seladb:dev Jun 12, 2025
43 checks passed
@Dimi1010 Dimi1010 deleted the refactor/cast-cleanup branch June 12, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants