Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to how CA certificate file is created #24

Closed
wants to merge 1 commit into from

Conversation

mathieu-aubin
Copy link

just for fun, seemed better plus i had time to kill heh

just for fun, seemed better plus i had time to kill heh
@sekunho
Copy link
Owner

sekunho commented May 1, 2022

Heyah! Thanks for the PR. If you have the time, could you explain this part to me, since I'm not so well-versed with bash?

cat <<- __EOF__ > $LOC
-----BEGIN CERTIFICATE-----
$CA_CERT
-----END CERTIFICATE-----
__EOF__

What does <<-__EOF__, or __EOF__ do?

@mathieu-aubin
Copy link
Author

It's called a "HERE DOC"

The link i gave you doesnt show much to help grasp the concept but basically...

<<- Redirect until marker is reached (to terminal/file/pipe. etc..)
__EOF__ Is the marker i used - could have used ENDCRT or whatever else
"__EOF__" This would have not allowed variable substitution, which we wanted

there are alot more things with it that you could enjoy, maybe

@sekunho
Copy link
Owner

sekunho commented Oct 26, 2022

This isn't applicable anymore because I changed the deployment strategy. But thanks for the PR, and for the explanation! 🙏

@sekunho sekunho closed this Oct 26, 2022
@sekunho sekunho added the wontfix This will not be worked on label Oct 26, 2022
@mathieu-aubin
Copy link
Author

This isn't applicable anymore because I changed the deployment strategy. But thanks for the PR, and for the explanation! pray

I was wondering... i see 'run' file hasn't changed and curious about what you say is/has changed?

Its OKAY if the PR has no value to you, really. But im genuinely curiius about what you meant by the previous

take care!

@sekunho
Copy link
Owner

sekunho commented Oct 31, 2022

I'm happy to elaborate.

The script itself hasn't changed but I'm no longer using it. I created a systemd service which runs the binary directly, and it assumes that the CA certificate is already present, and will be provided for in the VPS that it's running in. Hence why there's no need for me to echo its contents into a file, which is what the script was responsible for in the first place.

@sekunho sekunho changed the title useless change Change to how CA certificate file is created Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants