Refactor Errors and some module re-organizing
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekunho
force-pushed
the
refactor/sort-out-error-variants
branch
3 times, most recently
from
3c1f684 to
01ba930
Compare
sekunho
changed the title
Errors and some module re-organizing
*Better `Error`s* The `Error` data constructors defined by me, weren't that descriptive, and so the error messages in the client were impossible to deal with due to how vague they were. If something bad happens, the client has no idea if it was the server's fault, and even if it was there fault, they have no idea what they did wrong. So now there's enough context to distinguish if it's a 4xx or 5xx, and if it's the former, what can be done to fix it. *More organized modules* The modules weren't as organized before so that is _slightly_ better now. The DB connection stuff remain in the `db.rs` module, but the functions that queried the db for data now live in a `url.rs` module. There are still more things to be refactored. This just takes care of a sizable chunk of them.
sekunho
force-pushed
the
refactor/sort-out-error-variants
branch
from
01ba930 to
0791717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.