#3 Sigegv fix #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ediweissmann
added a commit
that referenced
this pull request
May 27, 2020
pbi-qfs
reviewed
Sep 2, 2020
| } else { | ||
| byte[] rgbData = getRGB(aImage); | ||
| return WebP.encodeRGB(aOptions, rgbData, aImage.getWidth(), aImage.getHeight(), aImage.getWidth() * 3); | ||
| ThreadLocal<WebPEncoderOptions> encoderThreadLocal = new ThreadLocal<>(); |
There was a problem hiding this comment.
Why is ThreadLocal here preferred over any other reference-holding container, e.g. a WebPEncoderOptions[] ?
And wouldn't calling an aOptions.noopForAvoidingGC() method in the finally block have the same effect, since it prevents removing the object until then? This would spare us creating the extra container object.
joostoudeman
pushed a commit
to joostoudeman/webp-imageio
that referenced
this pull request
Jun 16, 2023
Fix diffuse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.