Skip to content
This repository was archived by the owner on Oct 5, 2019. It is now read-only.

change the require string #130

Merged
merged 2 commits into from
May 10, 2016
Merged

change the require string #130

merged 2 commits into from
May 10, 2016

Conversation

super-ienien
Copy link
Contributor

It should be this nomenclature to load properly with a tool like require.js

It should be this nomenclature to load properly with a tool like require.js
@seiyria
Copy link
Owner

seiyria commented May 9, 2016

I'm going to need to see an example because I have no idea what this is, does, or means.

@super-ienien
Copy link
Contributor Author

it require the 'bootstrap-slider' module as you named it in npm

@seiyria
Copy link
Owner

seiyria commented May 9, 2016

Yeah, but I imagine it depends on what require is requiring from - bootstrap-slider exports to module.bootstrapSlider or window.bootstrapSlider. I don't know enough about this to say either way which is correct.

@super-ienien
Copy link
Contributor Author

In the case of require js, this is not very relevant. But in the case of browserify it load the bootstrap-slider module based on the name inside package.json. So 'boostrapSlider' doesn't work with browserify

@seiyria seiyria merged commit 601840d into seiyria:master May 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants