Track in-force governance rules and black-format the report helpers - #9
Merged
Conversation
CLAUDE.md carried sections 8-19 (sample-agnostic mutations, observability, retention guardrails, evolution policy, communication discipline, testing discipline, decomposition watchlist, performance policy, single-binary UX, architecture-map guardrails, commit conventions, compliance) plus the approved exceptions (EX-001/002/003) only in the working tree. These are the rules the project already treats as binding; track them in git so the committed file matches the governance in force.
Pre-existing formatting drift: report_helpers_risk.py had a wrapped boolean the formatter joins onto one line and report_helpers_symbolic.py a stray blank line. Formatting only, no behavior change; leaves both black-clean.
There was a problem hiding this comment.
Pull request overview
Tracks previously out-of-tree governance rules in CLAUDE.md and applies Black-only formatting cleanups to report helper modules in r2morph/core/.
Changes:
- Add governance sections 8–19 (plus exceptions) to
CLAUDE.mdso the project rules are versioned in git. - Black-format a wrapped boolean expression in
report_helpers_risk.py. - Remove a stray blank line in
report_helpers_symbolic.py.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
r2morph/core/report_helpers_symbolic.py |
Removes a stray blank line (formatting-only). |
r2morph/core/report_helpers_risk.py |
Reflows a boolean expression to Black output under the project’s configured line length. |
CLAUDE.md |
Adds the missing governance sections (8–19) and documents approved exceptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## 11. Política de evolución | ||
|
|
||
| - **Sin compatibilidad legacy para features propias.** Cuando una feature, API interna, flag de CLI, campo de report, perfil o adaptador reemplaza a otro más viejo, se elimina la implementación obsoleta, sus docs, tests, fixtures, alias y rutas de fallback en el mismo cambio. No se preserva comportamiento legacy solo porque una interfaz interna antigua existía. La compatibilidad **solo** es válida cuando modela contratos externos públicos que r2morph debe soportar: formatos PE/ELF/Mach-O, semántica de ISA, esquemas de report versionados públicamente (`report_schema.json`, SARIF). | ||
| - **El código es propio.** Herramientas, papers y proyectos open-source externos pueden inspirar el diseño, pero el código que se commitea es original y alineado con la arquitectura de r2morph. No se porta, copia ni transliterar implementaciones de terceros. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits pre-existing working-tree state that predates the flag-transfer feature and is unrelated to it, kept out of that PR.
report_helpers_risk.py(wrapped boolean) andreport_helpers_symbolic.py(stray blank line). Formatting only, no behavior change.Not included:
fixtures/optimized_binaries/exception_testhas an opaque working-tree change (same size, different content, unclear provenance) — left untouched rather than merged unverified.