Conversation
udpatil
force-pushed
the
uday/ramp-loadtest
branch
from
f5059f9 to
a75b137
Compare
masih
reviewed
Aug 19, 2025
| // Ramping loadtest will being at the StartTps and spend LoadTime at each step, ending when we violate the chain SLO of | ||
| // 1 block per second over a given ramp period (as measured in the back half of the ramp time) | ||
| // If we successfully pass a given TPS, we will pause for PauseTime, and then start the next step. | ||
| // If we fail to pass a given TPS, we will stop the loadtest. |
Contributor
There was a problem hiding this comment.
Write this as godoc of Ramper or package level godoc instead of inline comment?
| r.Step, r.TargetTPS, r.WindowBlockStats.FormatBlockStats()) | ||
| } | ||
|
|
||
| type Ramper struct { |
Contributor
There was a problem hiding this comment.
Is there anything here that we want otel metrics for too? It doesn't have to happen in this PR but if the lines are small enough I would also consider adding metrics.
stevenlanders
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a ramping loadtest that can be used test progressive levels of load on a loadtest cluster to identify the point at which we experience failure to meet SLO (which is p90 block times of 1s in this case). This can be run with any scenario as specified, and we can configure later CI to run loadtests for varying scenarios to evaluate TPS under different load profiles.