Skip to content

Comments

Checks: run broken link checks per pr#267

Closed
kollegian wants to merge 2 commits intomainfrom
checks/enforce-links-check
Closed

Checks: run broken link checks per pr#267
kollegian wants to merge 2 commits intomainfrom
checks/enforce-links-check

Conversation

@kollegian
Copy link
Contributor

@kollegian kollegian commented Mar 27, 2025

What is the purpose of the change?

Run checking links action per pr

Describe the changes to the documentation

None

Notes

@kollegian kollegian marked this pull request as ready for review April 3, 2025 14:19
@kollegian kollegian requested a review from a team as a code owner April 3, 2025 14:19
@alexander-sei
Copy link
Collaborator

This can't work because the checkLinks.ts is always pointing to docs.sei.io so it actually never checks the links inside of the PR itself:

	const baseUrl = 'https://www.docs.sei.io/';
	await crawlPages(baseUrl, browserInstance, 'main');

	fs.writeFileSync('brokenLinks.json', JSON.stringify([...brokenLinks], null, 2));

Copy link
Collaborator

@alexander-sei alexander-sei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work on the PR itself

@kollegian
Copy link
Contributor Author

Doesn't work on the PR itself

You are most certainly right.

@kollegian kollegian closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants