-
Notifications
You must be signed in to change notification settings - Fork 17
Feature: Add incremental snapshots #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| for _, node := range modifiedNodes { | ||
| if node.Value == nil { | ||
| // Delete operation | ||
| baseTree.Remove(node.Key) | ||
| } else { | ||
| // Set operation | ||
| baseTree.Set(node.Key, node.Value) | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for _, node := range nodes { | ||
| if node.Value != nil { | ||
| tree.Set(node.Key, node.Value) | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (31.31%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 63.67% 56.97% -6.71%
==========================================
Files 28 30 +2
Lines 4047 5050 +1003
==========================================
+ Hits 2577 2877 +300
- Misses 1171 1837 +666
- Partials 299 336 +37
🚀 New features to boost your workflow:
|
| for _, node := range os.modifications { | ||
| if !callback(node) { | ||
| return | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for _, node := range os.modifications { | ||
| if node.Value == nil { | ||
| baseTree.Remove(node.Key) | ||
| } else { | ||
| baseTree.Set(node.Key, node.Value) | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Describe your changes and provide context
Testing performed to validate your change