Skip to content

Conversation

@yzang2019
Copy link
Collaborator

Describe your changes and provide context

Testing performed to validate your change

Comment on lines +877 to +885
for _, node := range modifiedNodes {
if node.Value == nil {
// Delete operation
baseTree.Remove(node.Key)
} else {
// Set operation
baseTree.Set(node.Key, node.Value)
}
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Comment on lines +944 to +948
for _, node := range nodes {
if node.Value != nil {
tree.Set(node.Key, node.Value)
}
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 31.31115% with 702 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.97%. Comparing base (930c590) to head (b20384e).

Files with missing lines Patch % Lines
sc/memiavl/snapshot.go 7.46% 486 Missing and 10 partials ⚠️
sc/memiavl/incremental_snapshot.go 54.50% 93 Missing and 23 partials ⚠️
sc/memiavl/overlay_snapshot.go 56.49% 74 Missing and 3 partials ⚠️
sc/memiavl/tree.go 38.46% 8 Missing ⚠️
ss/pebbledb/db.go 0.00% 4 Missing ⚠️
sc/memiavl/db.go 94.73% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (31.31%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (56.97%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   63.67%   56.97%   -6.71%     
==========================================
  Files          28       30       +2     
  Lines        4047     5050    +1003     
==========================================
+ Hits         2577     2877     +300     
- Misses       1171     1837     +666     
- Partials      299      336      +37     
Files with missing lines Coverage Δ
sc/memiavl/filelock.go 53.84% <ø> (ø)
sc/memiavl/mem_node.go 95.16% <ø> (ø)
sc/memiavl/multitree.go 70.79% <100.00%> (-0.96%) ⬇️
sc/memiavl/opts.go 85.71% <100.00%> (+2.38%) ⬆️
sc/memiavl/persisted_node.go 94.53% <100.00%> (ø)
sc/memiavl/db.go 59.25% <94.73%> (+0.98%) ⬆️
ss/pebbledb/db.go 57.18% <0.00%> (-0.09%) ⬇️
sc/memiavl/tree.go 74.35% <38.46%> (-2.43%) ⬇️
sc/memiavl/overlay_snapshot.go 56.49% <56.49%> (ø)
sc/memiavl/incremental_snapshot.go 54.50% <54.50%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +201 to +205
for _, node := range os.modifications {
if !callback(node) {
return
}
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Comment on lines +213 to +219
for _, node := range os.modifications {
if node.Value == nil {
baseTree.Remove(node.Key)
} else {
baseTree.Set(node.Key, node.Value)
}
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants