Make PebbleDB iterator iterative #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
force-pushed
the
tony/iterative-next
branch
from
cd1db1c to
3043146
Compare
yzang2019
approved these changes
May 8, 2025
Kbhat1
approved these changes
May 9, 2025
codchen
force-pushed
the
tony/iterative-next
branch
from
3043146 to
357268a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
The PebbleDB iterator was working in a recursive fashion, which may cause stack overflow issue when there are too many versions to traverse over. This PR changes the logic to be iterative without modifications to behavior.
Testing performed to validate your change
unit tests