Add gov proposal handler for acl #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsu522
approved these changes
Oct 4, 2022
| @@ -0,0 +1,22 @@ | |||
| { | |||
|
|
||
| func HandleMsgUpdateResourceDependencyMappingProposal(ctx sdk.Context, k *keeper.Keeper, p *types.MsgUpdateResourceDependencyMappingProposal) error { | ||
| for _, resourceDepMapping := range p.MessageDependencyMapping { | ||
| k.SetResourceDependencyMapping(ctx, resourceDepMapping) |
There was a problem hiding this comment.
do we do any checks over resourceDepMapping?
There was a problem hiding this comment.
Mainly just the proto serialization checks -- all the fields that are not free form are ENUMs so the proto serialization should also cover those cases
BrandonWeng
added a commit
that referenced
this pull request
Oct 14, 2022
Adding a handler for handling gov proposals from CLI in order to update the dependency mappings for access control module. Will follow up with another PR to handle deletes ### Testing Ran these commands and see that the dep mapping updated ``` seid tx staking delegate seivaloper1r9syjw4kdpjr8a6v38qmvn4dmmrnl869kmgsvr 59999000001341816640usei --from brando --chain-id sei-chain -b block -y --fees 2000usei seid tx gov submit-proposal update-resource-dependency-mapping ../brando/acl-gov.json --from brando --fees=10000000usei --gas=5000000 --chain-id sei-chain -b block seid tx gov deposit 1 10000000usei --chain-id sei-chain --from brando --fees=10000000usei --gas=5000000 -b block -y seid tx gov vote 1 yes --chain-id sei-chain --from brando -b block -y --fees=10000000usei ``` 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a handler for handling gov proposals from CLI in order to update the dependency mappings for access control module. Will follow up with another PR to handle deletes
Testing
Ran these commands and see that the dep mapping updated