Oracle parallel #334
Merged
Oracle parallel #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udpatil
requested review from
codchen,
BrandonWeng,
philipsu522 and
eric-zhu-uw
udpatil
commented
Oct 25, 2022
go.mod
Outdated
| @@ -131,7 +131,7 @@ require ( | |||
| ) | |||
|
|
|||
| replace ( | |||
| github.com/cosmos/cosmos-sdk => github.com/sei-protocol/sei-cosmos v0.1.176 | |||
| github.com/cosmos/cosmos-sdk => ../sei-cosmos //github.com/sei-protocol/sei-cosmos v0.1.193 | |||
There was a problem hiding this comment.
reminder to remove local dep
* [oracle] Remove oracle prevote * lint * remove prevote from store
udpatil
force-pushed
the
oracle-parallel
branch
from
894fabe to
0fd95f0
Compare
BrandonWeng
reviewed
Oct 26, 2022
| for i := 0; i < int(config.Rounds); i++ { | ||
| fmt.Printf("Preparing %d-th round\n", i) | ||
|
|
||
| wg := &sync.WaitGroup{} | ||
| var senders []func() | ||
| workgroups = append(workgroups, wg) | ||
| if config.MessageType != "none" { |
There was a problem hiding this comment.
I added a "none" type so that I could run ONLY oracle txs on the cluster, if we don't think we want to keep it I can remove it
BrandonWeng
reviewed
Oct 26, 2022
loadtest/loadtest_client.go
Outdated
Comment on lines
125
to
138
| for _, valKey := range valKeys { | ||
| // generate oracle tx | ||
| msg := generateOracleMessage(valKey) | ||
| txBuilder := TestConfig.TxConfig.NewTxBuilder() | ||
| _ = txBuilder.SetMsgs(msg) | ||
| seqDelta := uint64(i) | ||
| mode := typestx.BroadcastMode_BROADCAST_MODE_SYNC | ||
| sender := SendTx(valKey, &txBuilder, mode, seqDelta, *c) | ||
| wg.Add(1) | ||
| senders = append(senders, func() { | ||
| defer wg.Done() | ||
| sender() | ||
| }) | ||
| } |
There was a problem hiding this comment.
kind of a nit but it seems like we have multiple things happening in preparing round now, it would be nice if they're in separate methods
There was a problem hiding this comment.
yeah good point, I'll make a helper fn
BrandonWeng
reviewed
Oct 26, 2022
Comment on lines
-48
to
-51
| case *oracletypes.MsgAggregateExchangeRatePrevote: | ||
| feederAddr, _ := sdk.AccAddressFromBech32(m.Feeder) | ||
| valAddr, _ := sdk.ValAddressFromBech32(m.Validator) | ||
| deps = append(deps, aclutils.GetOracleReadAccessOpsForValAndFeeder(feederAddr, valAddr)...) |
There was a problem hiding this comment.
is this part of the cherry-picked changes?
There was a problem hiding this comment.
yup, it removed the prevote and combined vote from oracle
There was a problem hiding this comment.
well, this exact change wasn't cherry picked, but I removed this to match the removal in the cherry picked section
BrandonWeng
approved these changes
Oct 26, 2022
udpatil
added a commit
that referenced
this pull request
Oct 28, 2022
* [oracle] Remove oracle prevote (#249) * [oracle] Remove oracle prevote * lint * remove prevote from store * [acl] Add oracle parallelization dependencies * [loadtest] Add oracle voting to loadtest * go mod tidy * modified key import * adjust loadtest * remove none msg type * update config * add non message type * add validation unit tests for oracle mapping * refactor loadtest and use new sei-cosmos tag * fix loadtest config * add loadtest to makefile * fix * fix tabs * lint * go mod tidy * refactor loadtest to separate function * fix * fix refactor
udpatil
added a commit
that referenced
this pull request
Oct 28, 2022
* [oracle] Remove oracle prevote (#249) * [oracle] Remove oracle prevote * lint * remove prevote from store * [acl] Add oracle parallelization dependencies * [loadtest] Add oracle voting to loadtest * go mod tidy * modified key import * adjust loadtest * remove none msg type * update config * add non message type * add validation unit tests for oracle mapping * refactor loadtest and use new sei-cosmos tag * fix loadtest config * add loadtest to makefile * fix * fix tabs * lint * go mod tidy * refactor loadtest to separate function * fix * fix refactor
udpatil
added a commit
that referenced
this pull request
Nov 1, 2022
* [oracle] Remove oracle prevote (#249) * [oracle] Remove oracle prevote * lint * remove prevote from store * [acl] Add oracle parallelization dependencies * [loadtest] Add oracle voting to loadtest * go mod tidy * modified key import * adjust loadtest * remove none msg type * update config * add non message type * add validation unit tests for oracle mapping * refactor loadtest and use new sei-cosmos tag * fix loadtest config * add loadtest to makefile * fix * fix tabs * lint * go mod tidy * refactor loadtest to separate function * fix * fix refactor
udpatil
added a commit
that referenced
this pull request
Nov 1, 2022
* [oracle] Remove oracle prevote (#249) * [oracle] Remove oracle prevote * lint * remove prevote from store * [acl] Add oracle parallelization dependencies * [loadtest] Add oracle voting to loadtest * go mod tidy * modified key import * adjust loadtest * remove none msg type * update config * add non message type * add validation unit tests for oracle mapping * refactor loadtest and use new sei-cosmos tag * fix loadtest config * add loadtest to makefile * fix * fix tabs * lint * go mod tidy * refactor loadtest to separate function * fix * fix refactor
udpatil
added a commit
that referenced
this pull request
Nov 1, 2022
* Revert "Update Antehandler resource depedencies (#354)" This reverts commit 6c672fb. * Revert "update staking validation identifier (#353)" This reverts commit 8a17c26. * Revert "Update Oracle Parallel Tx Resource Identifiers (#351)" This reverts commit c9229ab. * Revert "Update IdentifierTemplate for TokenFactory (#350)" This reverts commit e81fc93. * Revert "[loadtest] Loadtest fixes" This reverts commit 68bfab5. * Revert "fix unit tests" This reverts commit 49eb809. * Revert "Fix Bank Send Unit Tests (#348)" This reverts commit 9c11837. * Revert "integrate with sei-cosmos changes (#347)" This reverts commit e1b1790. * Revert "Validate Concurrent Messages + Update BankSend (#345)" This reverts commit e4d3176. * Revert "Add concurrency for BurnMsg and MintMsg (#331)" This reverts commit 4a5cff0. * Revert "Ezhu/granularize staking resources (#343)" This reverts commit 90e288c. * Revert "Oracle parallel (#334)" This reverts commit 67c0db3. * Revert "Ezhu/staking dep gen mappings v2 rebase (#338)" This reverts commit 1324183. * Revert "Refactor Loadtest script (#336)" This reverts commit c8b83c7. * Revert "Optimize genesis account creation script (#320)" This reverts commit a0c0306. * Revert "Wasm gov (#316)" This reverts commit c3b421b. * Revert "Lazy Deposit All Module Accounts During EndBlock (#313)" This reverts commit 5ad4d9b. * Revert "Wasm signal (#305)" This reverts commit 206f2bb. * Revert "Add dependencies for ante handlers that read/write accounts (#314)" This reverts commit 5d39f90. * Revert "Add Gasless decorator back and remove CountTxDecorator (#311)" This reverts commit 93fa4bd. * Revert "Branch another cache for all transactions (#309)" This reverts commit c2ce1ed. * Revert "Add msg send dynamic access ops (#303)" This reverts commit 2c5f14e. * Revert "[ante] Add ante dep generator default behavior (#294)" This reverts commit 0ada1db. * Revert "Add more parallel TX metrics (#296)" This reverts commit 567ffd9. * Revert "Add aclmapping options and mapping folder (#287)" This reverts commit c9522a5. * Revert "Bump sei-cosmos and sei-tendermint for 2.0.0beta (#293)" This reverts commit d9254b6. * Revert "Cherry-pick loadtesting changes and make a fix for parallel tx (#288)" This reverts commit 255fec9. * Revert "[app] refactored graph into acl module (#286)" This reverts commit 9b2d204. * Revert "Add gov proposal handler for acl (#277)" This reverts commit bbb5a50. * Revert "Fix for DAG building switch cases (#282)" This reverts commit 9eebc8e. * Revert "Optimize signals (#280)" This reverts commit fd9a3b6. * Revert "[app] Add behavior to process blocks with gov txs sync (#276)" This reverts commit ea2a906. * Revert "[graph] Move metric to dag builder helper (#275)" This reverts commit c530c02. * Revert "Fixes for parallel TX and metrics (#272)" This reverts commit 30207e7. * Revert "[graph] Add resource hierarchy to dependency graph (#268)" This reverts commit da7c070. * Revert "Revert "Parallel TX Synchrnous Testing"" This reverts commit f343740. * Revert "Parallel TX Synchrnous Testing" This reverts commit b95b44c. * Revert "Dag optimization (#263)" This reverts commit ac3fdbf. * Revert "Create Channels from DAG (#261)" This reverts commit 35b9cf4. * Revert "[accesscontrol] Add dependency dag (#258)" This reverts commit 6721845. * Revert "Register accesscontrol module (#257)" This reverts commit 3e34d34.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This contains the implementation for oracle vote parallelization via aclmapping dynamic generators. Additionally, this PR is stacked on top of a cherry picked PR that previously modified oracle so as to apply the parallelizatin changes to the latest oracle code.
Also added a makefile target to build loadtest for faster development
Testing performed to validate your change
Tested using loadtest cluster, and also added unit tests for the parallelization dynamic generators to validate the access operations to ensure that they can't be unknowingly changed to violate the validation steps.