Skip to content

merged unconditional and persistent peers status#2977

Merged
pompon0 merged 2 commits intomainfrom
gprusak-outbound0
Feb 25, 2026
Merged

merged unconditional and persistent peers status#2977
pompon0 merged 2 commits intomainfrom
gprusak-outbound0

Conversation

@pompon0
Copy link
Contributor

@pompon0 pompon0 commented Feb 25, 2026

unconditional peers which have no corresponding node addresses in the persistent peers list, will be treated from now on as peers that our node should NOT dial, just accept incoming connections from (so essentially as persistent peers with no addresses to dial). This is a simplification: the way it used to work was that unconditional peers could be dialed together with regular peers, but once a connection was established, it was treated same as persistent (it didn't count towards limits). I don't think we need this quirky semantics.

@github-actions
Copy link

github-actions bot commented Feb 25, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 25, 2026, 5:31 PM

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.78%. Comparing base (7298da1) to head (cff6da2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2977       +/-   ##
===========================================
+ Coverage   58.10%   71.78%   +13.67%     
===========================================
  Files        2109       21     -2088     
  Lines      173384     1921   -171463     
===========================================
- Hits       100749     1379    -99370     
+ Misses      63683      444    -63239     
+ Partials     8952       98     -8854     
Flag Coverage Δ
sei-chain 72.52% <100.00%> (+14.44%) ⬆️
sei-db 69.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/p2p/peermanager.go 87.21% <100.00%> (-4.30%) ⬇️

... and 2090 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 merged commit 82fb610 into main Feb 25, 2026
38 checks passed
@pompon0 pompon0 deleted the gprusak-outbound0 branch February 25, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants