merged unconditional and persistent peers status#2977
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2977 +/- ##
===========================================
+ Coverage 58.10% 71.78% +13.67%
===========================================
Files 2109 21 -2088
Lines 173384 1921 -171463
===========================================
- Hits 100749 1379 -99370
+ Misses 63683 444 -63239
+ Partials 8952 98 -8854
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sei-will
approved these changes
Feb 25, 2026
wen-coding
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unconditional peers which have no corresponding node addresses in the persistent peers list, will be treated from now on as peers that our node should NOT dial, just accept incoming connections from (so essentially as persistent peers with no addresses to dial). This is a simplification: the way it used to work was that unconditional peers could be dialed together with regular peers, but once a connection was established, it was treated same as persistent (it didn't count towards limits). I don't think we need this quirky semantics.