Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2963 +/- ##
===========================================
- Coverage 58.14% 52.11% -6.03%
===========================================
Files 2107 20 -2087
Lines 173322 3730 -169592
===========================================
- Hits 100780 1944 -98836
+ Misses 63602 1611 -61991
+ Partials 8940 175 -8765
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
145d865 to
0a75710
Compare
codchen
approved these changes
Feb 25, 2026
| expectedNonce := app.GigaEvmKeeper.GetNonce(ctx, sender) | ||
| txNonce := ethTx.Nonce() | ||
| if txNonce != expectedNonce { | ||
| // Calculate intrinsic gas for reporting (V2 reports this as gasUsed) |
Collaborator
There was a problem hiding this comment.
can you link where this happens for v2? from what I see the v2 ante handler would just exit with 0 gas used.
not blocking though since gas used no longer affects consensus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Reopening #2877 against main
fixes mismatch of this block. there are 2 txs (don't show up on seiscan) that have invalid nonces:
In this case we just bail WITHOUT bumping the nonce.
Testing performed to validate your change
tests pass, get us past the block in question.