Draft
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Empty commit to trigger CI and check if TestTimelyProposal, TestAvailClientServer, TestStateLock_NoPOL, and TestStateLock_POLSafety1 fail on unmodified main. Co-authored-by: Cursor <cursoragent@cursor.com>
- pbts_test.go: bump timeoutPropose from 10-50ms to 500ms so proposals arrive before the timeout fires under CI load - syncer_test.go: bump sleep from 50ms to 500ms so the goroutine has time to process chunk refetch under load - node_test.go: bump context timeout from 10s to 60s so the node has time to produce its first block under load Co-authored-by: Cursor <cursoragent@cursor.com>
Many consensus tests (e.g. TestStateLock_POLSafety1, TestStateLock_NoPOL) race between SetProposalAndBlock and the propose timeout. Under CI load, 40ms is not enough margin for the proposal to be delivered before the timeout fires, causing the node to prevote nil and the test to fail. Increasing to 500ms gives ample margin while keeping test runtime acceptable (~500ms per propose-timeout wait step). Co-authored-by: Cursor <cursoragent@cursor.com>
500ms was overly generous and could contribute to slow test suites under CI. 200ms still gives 5x margin over the original 40ms, which is enough to prevent the SetProposalAndBlock race from losing to the timeout. Co-authored-by: Cursor <cursoragent@cursor.com>
wen-coding
force-pushed
the
wen/test_flaky_ci
branch
from
c725944 to
77a2031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Empty commit on unmodified main to verify whether these CI tests are pre-existing flaky:
TestTimelyProposalTestAvailClientServerTestStateLock_NoPOLTestStateLock_POLSafety1Draft PR — do not merge.
Made with Cursor