Skip to content

fix: benchmark-compare port slots start at offset 1000#2905

Merged
pdrobnjak merged 1 commit intopd/benchmark-profiling-improvementsfrom
pd/fix-benchmark-port-collision
Feb 17, 2026
Merged

fix: benchmark-compare port slots start at offset 1000#2905
pdrobnjak merged 1 commit intopd/benchmark-profiling-improvementsfrom
pd/fix-benchmark-port-collision

Conversation

@pdrobnjak
Copy link
Contributor

Summary

  • benchmark-compare.sh slot 0 previously mapped to RUN_PORT_OFFSET=0, which uses the same default ports as standalone benchmark.sh (offset 0)
  • If a stale seid from a previous standalone run is holding those ports, the baseline node in a compare run panics with bind: address already in use
  • Fix: change slot-to-offset mapping from slot * 1000 to 1000 + slot * 1000, so compare runs start at offset 1000+ and never overlap with standalone benchmark default ports

Complements #2900 which added auto-claim port offsets to benchmark.sh itself.

Test plan

  • Run benchmark-compare.sh — first slot should claim offset 1000, not 0
  • Run standalone benchmark.sh concurrently with benchmark-compare.sh — no port collisions
  • Multiple concurrent benchmark-compare.sh invocations still auto-claim non-overlapping slots

🤖 Generated with Claude Code

…sion

Slot 0 previously mapped to RUN_PORT_OFFSET=0, colliding with standalone
benchmark.sh default ports. Now slots start at 1000 so concurrent compare
runs never overlap with standalone benchmark runs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Feb 17, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 17, 2026, 3:03 PM

@pdrobnjak pdrobnjak self-assigned this Feb 17, 2026
@pdrobnjak pdrobnjak merged commit 7854f49 into pd/benchmark-profiling-improvements Feb 17, 2026
13 of 15 checks passed
@pdrobnjak pdrobnjak deleted the pd/fix-benchmark-port-collision branch February 17, 2026 15:02
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.35%. Comparing base (4b3735f) to head (c770144).
⚠️ Report is 1 commits behind head on pd/benchmark-profiling-improvements.

❗ There is a different number of reports uploaded between BASE (4b3735f) and HEAD (c770144). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4b3735f) HEAD (c770144)
sei-chain 1 0
Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                            @@
##           pd/benchmark-profiling-improvements    #2905       +/-   ##
========================================================================
- Coverage                                57.17%   48.35%    -8.83%     
========================================================================
  Files                                     2091      671     -1420     
  Lines                                   171173    50615   -120558     
========================================================================
- Hits                                     97872    24474    -73398     
+ Misses                                   64583    24000    -40583     
+ Partials                                  8718     2141     -6577     
Flag Coverage Δ
sei-chain ?
sei-cosmos 48.16% <ø> (+<0.01%) ⬆️
sei-db 68.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1543 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant