fix: benchmark-compare port slots start at offset 1000#2905
Merged
pdrobnjak merged 1 commit intopd/benchmark-profiling-improvementsfrom Feb 17, 2026
Merged
Conversation
…sion Slot 0 previously mapped to RUN_PORT_OFFSET=0, colliding with standalone benchmark.sh default ports. Now slots start at 1000 so concurrent compare runs never overlap with standalone benchmark runs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
7854f49
into
pd/benchmark-profiling-improvements
13 of 15 checks passed
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## pd/benchmark-profiling-improvements #2905 +/- ##
========================================================================
- Coverage 57.17% 48.35% -8.83%
========================================================================
Files 2091 671 -1420
Lines 171173 50615 -120558
========================================================================
- Hits 97872 24474 -73398
+ Misses 64583 24000 -40583
+ Partials 8718 2141 -6577
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmark-compare.shslot 0 previously mapped toRUN_PORT_OFFSET=0, which uses the same default ports as standalonebenchmark.sh(offset 0)seidfrom a previous standalone run is holding those ports, the baseline node in a compare run panics withbind: address already in useslot * 1000to1000 + slot * 1000, so compare runs start at offset 1000+ and never overlap with standalone benchmark default portsComplements #2900 which added auto-claim port offsets to
benchmark.shitself.Test plan
benchmark-compare.sh— first slot should claim offset 1000, not 0benchmark.shconcurrently withbenchmark-compare.sh— no port collisionsbenchmark-compare.shinvocations still auto-claim non-overlapping slots🤖 Generated with Claude Code