Check against sstore block availability when processing eth_getLogs #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udpatil
force-pushed
the
uday/check-receipt-latest-version
branch
from
f12b81f to
d4fc8cd
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (57.14%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2433 +/- ##
=========================================
+ Coverage 0 27.11% +27.11%
=========================================
Files 0 1464 +1464
Lines 0 144423 +144423
=========================================
+ Hits 0 39154 +39154
- Misses 0 101905 +101905
- Partials 0 3364 +3364
🚀 New features to boost your workflow:
|
stevenlanders
approved these changes
Oct 3, 2025
yzang2019
reviewed
Oct 3, 2025
| // get block number from hash and compare to latest | ||
| latestReceiptVersion, err := a.logFetcher.k.GetLatestReceiptVersion(a.logFetcher.ctxProvider(LatestCtxHeight)) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
Currently if it returns an error, we should probably fall back to the previous approach to assume latestVersion=latestblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This checks against the latest available version for receiptStore so that we can properly error on eth_getLogs if/when we haven't yet flushed one or more of the blocks within the queried range.
Testing performed to validate your change
Unit tests