Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back block tests removed from partial refund #2055

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

jewei1997
Copy link
Contributor

@jewei1997 jewei1997 commented Jan 25, 2025

Describe your changes and provide context

We originally removed some block tests because they were failing due to us removing the full refund of unused gas (https://github.com/sei-protocol/sei-chain/pull/1871/files#diff-0adc342d2882ffb81750cb8734fb7ab5c0a7393082b452370b3aacff3df49777R37-R39). However, we've reverted that change, so adding back these tests.

Testing performed to validate your change

existing tests

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.53%. Comparing base (eeb164d) to head (6ac9280).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2055      +/-   ##
==========================================
+ Coverage   61.31%   61.53%   +0.22%     
==========================================
  Files         264      264              
  Lines       24589    24589              
==========================================
+ Hits        15076    15131      +55     
+ Misses       8385     8328      -57     
- Partials     1128     1130       +2     

see 4 files with indirect coverage changes

@jewei1997 jewei1997 enabled auto-merge (squash) January 27, 2025 15:08
@jewei1997 jewei1997 merged commit f7a1d47 into main Jan 27, 2025
47 checks passed
@jewei1997 jewei1997 deleted the add-back-block-tests-full-gas-refund branch January 27, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants