Add logic to remove a small number of tx hashes each block #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -298,6 +298,9 @@ | |||
| // EndBlock executes all ABCI EndBlock logic respective to the evm module. It | |||
| // returns no validator updates. | |||
| func (am AppModule) EndBlock(ctx sdk.Context, req abci.RequestEndBlock) []abci.ValidatorUpdate { | |||
| // TODO: remove after all TxHashes have been removed | |||
| am.keeper.RemoveFirstNTxHashes(ctx, keeper.DefaultTxHashesToRemove) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
==========================================
+ Coverage 61.28% 61.49% +0.21%
==========================================
Files 264 265 +1
Lines 24566 24581 +15
==========================================
+ Hits 15056 15117 +61
+ Misses 8384 8335 -49
- Partials 1126 1129 +3
|
philipsu522
reviewed
Jan 21, 2025
| @@ -298,6 +298,9 @@ func (am AppModule) BeginBlock(ctx sdk.Context, _ abci.RequestBeginBlock) { | |||
| // EndBlock executes all ABCI EndBlock logic respective to the evm module. It | |||
| // returns no validator updates. | |||
| func (am AppModule) EndBlock(ctx sdk.Context, req abci.RequestEndBlock) []abci.ValidatorUpdate { | |||
| // TODO: remove after all TxHashes have been removed | |||
There was a problem hiding this comment.
could we do this every 10 blocks? just so we spread it out and it doesn't look like block times are just degrading?
yzang2019
approved these changes
Jan 31, 2025
codchen
force-pushed
the
tony/remove-tx-hashes-slow
branch
from
fe92e36 to
98a3e70
Compare
codchen
force-pushed
the
tony/remove-tx-hashes-slow
branch
from
98a3e70 to
b4d5dff
Compare
philipsu522
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Remove 100 tx hashes every block until all tx hashes are deleted.
Testing performed to validate your change
unit test